mirror of
https://we.phorge.it/source/phorge.git
synced 2024-09-23 02:38:48 +02:00
a4e8fd2289
Summary: Ref T2230. Very rarely, even though we've flushed the connection and sent all the data, we'll close the connection before Git is happy with it and it will flip out with an error like this: fatal: The remote end hung up unexpectedly fatal: early EOF fatal: index-pack failed This is hard to reproduce because it depends on the order of read/write operations we can't directly control. I only saw it about 2% of the time, by just running `git pull` over and over again. Waiting for Git to close its side of the connection seems to fix it. Test Plan: Ran `git clone` a ton of times without seeing the error again. Ran `git push` a ton of times with new commits. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T2230 Differential Revision: https://secure.phabricator.com/D7558
23 lines
686 B
PHP
23 lines
686 B
PHP
<?php
|
|
|
|
abstract class DiffusionSSHGitWorkflow extends DiffusionSSHWorkflow {
|
|
|
|
protected function writeError($message) {
|
|
// Git assumes we'll add our own newlines.
|
|
return parent::writeError($message."\n");
|
|
}
|
|
|
|
protected function waitForGitClient() {
|
|
$io_channel = $this->getIOChannel();
|
|
|
|
// If we don't wait for the client to close the connection, `git` will
|
|
// consider it an early abort and fail. Sit around until Git is comfortable
|
|
// that it really received all the data.
|
|
while ($io_channel->isOpenForReading()) {
|
|
$io_channel->update();
|
|
$this->getErrorChannel()->flush();
|
|
PhutilChannel::waitForAny(array($io_channel));
|
|
}
|
|
}
|
|
|
|
}
|