1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 01:32:42 +01:00
phorge-phorge/src/applications/project
epriestley 48a3760814 Correct a bug where milestone "spacePHID" columns could become desynchronized
Summary:
Depends on D20041. See PHI1046. If you do this:

- Create a parent project called "Crab" in Space 1.
- Create a milestone called "Left Claw".
- Shift "Crab" to Space 2.
- Create a milestone called "Right Claw".

...you currently end up with "Left Claw" in the wrong `spacePHID` in the database. At the application level it's in the correct space, but when we `WHERE ... AND spacePHID IN (...)` we can incorrectly filter it out.

Test Plan:
  - Did the above setup.
  - Saved "Crab", saw the space fix itself.
  - Put things back in the broken state.
  - Ran the migration script, saw things fix themselves again.

Reviewers: amckinley

Reviewed By: amckinley

Subscribers: aeiser, PHID-OPKG-gm6ozazyms6q6i22gyam

Differential Revision: https://secure.phabricator.com/D20063
2019-01-30 19:41:49 -08:00
..
__tests__ Add a "members of all projects" (vs "...any project") custom policy rule to the upstream 2018-06-12 11:51:51 -07:00
application Add Dashboards as a default pinned application 2017-03-21 11:10:20 -07:00
capability Add default View, Edit, and Join Policies to Projects 2014-11-21 11:22:17 -08:00
command Implement a "!projects" mail command 2015-04-01 11:51:51 -07:00
conduit Migrate Project color to modular transactions 2017-05-18 16:46:06 -07:00
config Support subtypes in Projects 2019-01-30 06:17:55 -08:00
constants Allow workboard background colors to be configured 2016-02-16 08:15:12 -08:00
controller Support subtypes in Projects 2019-01-30 06:17:55 -08:00
customfield Fix errors found by PHPStan 2017-02-17 10:10:15 +00:00
edge Replace subscribe/unsubscribe for projects with explicit mail setting 2016-01-19 19:39:02 -08:00
editor Correct a bug where milestone "spacePHID" columns could become desynchronized 2019-01-30 19:41:49 -08:00
engine Allow "Change Subtype" to be selected from the comment action stack 2018-11-28 13:40:40 -08:00
engineextension Modularize the "jump nav" behaviors in global search 2018-02-14 18:08:07 -08:00
events Property list view on Diffusion commits should show build status but not Subscriptions, Projects, or Tokens 2017-12-01 18:16:26 +00:00
herald Add "Committer's projects" and "Author's projects" fields to Herald commit rules 2018-02-27 14:33:12 -08:00
icon Test 0 and "" cases in Project Icon Config 2017-07-10 12:01:22 -07:00
interface Roughly implement milestone columns on workboards 2016-02-03 16:37:59 -08:00
lipsum Migrate Project status to modular transactions 2017-05-18 11:36:13 -07:00
mail phtize all the things 2015-05-22 21:16:39 +10:00
menuitem Prevent hiding the PhabricatorProjectDetailsProfileMenuItem 2017-12-23 11:38:05 -08:00
phid Add Editor-based mail stamps: actor, via, silent, encrypted, new, mention, self-actor, self-mention 2018-02-06 04:04:52 -08:00
policyrule Add a "members of all projects" (vs "...any project") custom policy rule to the upstream 2018-06-12 11:51:51 -07:00
query Support subtypes in Projects 2019-01-30 06:17:55 -08:00
remarkup Fix spelling 2017-10-09 10:48:04 -07:00
search Support Ferret engine in Projects 2017-09-07 13:24:23 -07:00
searchfield Fix a bad call when prefilling ApplicationSearch from ?projects=some_slug 2016-02-08 10:44:33 -08:00
storage Support subtypes in Projects 2019-01-30 06:17:55 -08:00
typeahead Support subtypes in Projects 2019-01-30 06:17:55 -08:00
view Support subtypes in Projects 2019-01-30 06:17:55 -08:00
xaction Move the "Can Lock Projects" check from requireCapabilities() to transaction validation 2018-08-16 10:56:00 -07:00