1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 11:22:40 +01:00
phorge-phorge/src/applications/files/conduit
epriestley 440ef5b7a7 Remove SHA1 file content hashing and make Files work without any hashing
Summary:
Ref T12464. We currently use SHA1 to detect when two files have the same content so we don't have to store two copies of the data.

Now that a SHA1 collision is known, this is theoretically dangerous. T12464 describes the shape of a possible attack.

Before replacing this with something more robust, shore things up so things work correctly if we don't hash at all. This mechanism is entirely optional; it only helps us store less data if some files are duplicates.

(This mechanism is also less important now than it once was, before we added temporary files.)

Test Plan: Uploaded multiple identical files, saw the uploads work and the files store separate copies of the same data.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12464

Differential Revision: https://secure.phabricator.com/D17619
2017-04-04 16:22:10 -07:00
..
FileAllocateConduitAPIMethod.php Remove SHA1 file content hashing and make Files work without any hashing 2017-04-04 16:22:10 -07:00
FileConduitAPIMethod.php phtize all the things 2015-05-22 21:16:39 +10:00
FileDownloadConduitAPIMethod.php phtize all the things 2015-05-22 21:16:39 +10:00
FileInfoConduitAPIMethod.php Provide a modern ("v3") API for querying files ("file.search") 2017-04-04 16:15:36 -07:00
FileQueryChunksConduitAPIMethod.php Give Conduit params/return/errors protected visibility 2015-04-13 11:58:35 -07:00
FileUploadChunkConduitAPIMethod.php Detect the MIME type of large files by examining the first chunk 2016-06-30 13:57:39 -07:00
FileUploadConduitAPIMethod.php Remove SHA1 file content hashing and make Files work without any hashing 2017-04-04 16:22:10 -07:00
FileUploadHashConduitAPIMethod.php Deprecate "file.uploadhash" 2017-04-04 16:18:26 -07:00
PhabricatorFileSearchConduitAPIMethod.php Provide a modern ("v3") API for querying files ("file.search") 2017-04-04 16:15:36 -07:00