mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-16 03:42:41 +01:00
8f3b342287
Summary: Give users better errors and UI: - For subpath SVN repositories, default the path to the subdirectory, not to "/". This makes the home screen useful and things generally less confusing. - For unparsed commits, show a more descriptive error message without the "blah blah" silliness. - For paths outside of the subpath parse tree, short circuit into an appropriate error message. - For foreign SVN stub commits (see D892), show an explicit message. Test Plan: Looked at unparsed commits, subpath repositories, foreign stub commits, and paths outside of the subpath parse tree. Received sensible error messages. Reviewers: jungejason, nh, tuomaspelkonen, aran Reviewed By: jungejason CC: aran, jungejason Differential Revision: 894
67 lines
1.8 KiB
PHP
67 lines
1.8 KiB
PHP
<?php
|
|
|
|
/*
|
|
* Copyright 2011 Facebook, Inc.
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
class DiffusionSvnRequest extends DiffusionRequest {
|
|
|
|
protected function initializeFromAphrontRequestDictionary(array $data) {
|
|
parent::initializeFromAphrontRequestDictionary($data);
|
|
|
|
if ($this->path === null) {
|
|
$subpath = $this->repository->getDetail('svn-subpath');
|
|
if ($subpath) {
|
|
$this->path = $subpath;
|
|
}
|
|
}
|
|
|
|
if (!strncmp($this->path, ':', 1)) {
|
|
$this->path = substr($this->path, 1);
|
|
$this->path = ltrim($this->path, '/');
|
|
}
|
|
}
|
|
|
|
public function getStableCommitName() {
|
|
if ($this->commit) {
|
|
return $this->commit;
|
|
}
|
|
|
|
if ($this->stableCommitName === null) {
|
|
$commit = id(new PhabricatorRepositoryCommit())
|
|
->loadOneWhere(
|
|
'repositoryID = %d ORDER BY epoch DESC LIMIT 1',
|
|
$this->getRepository()->getID());
|
|
if ($commit) {
|
|
$this->stableCommitName = $commit->getCommitIdentifier();
|
|
} else {
|
|
// For new repositories, we may not have parsed any commits yet. Call
|
|
// the stable commit "1" and avoid fataling.
|
|
$this->stableCommitName = 1;
|
|
}
|
|
}
|
|
|
|
return $this->stableCommitName;
|
|
}
|
|
|
|
public function getCommit() {
|
|
if ($this->commit) {
|
|
return $this->commit;
|
|
}
|
|
|
|
return $this->getStableCommitName();
|
|
}
|
|
|
|
}
|