1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-18 19:40:55 +01:00
phorge-phorge/src/storage
epriestley 260b40b84a Plug the establishConnection() Lisk isolation hole
Summary:
Currently you can still punch through Lisk isolation by calling
establishConnection(), and we do that all over the place. Rename getConnection()
to establishConnection() so that all existing callers are safe, and rename
establishConnection() to establishLiveConnection() so that it's not surprising
when this fails to stub in unit tests.

Not wedded to the name if anyone thinks "establishExternalConnection" or
something is clearer.

Test Plan:
Loaded site, browsed around, ran unit tests.

Reviewed By: aran
Reviewers: aran, tuomaspelkonen, jungejason
CC: aran
Differential Revision: 201
2011-05-01 08:05:02 -07:00
..
connection Provide connection isolation to Lisk and enable it by default in tests 2011-04-30 22:24:50 -07:00
exception Improve schema upgrade workflow for unprivileged users 2011-04-30 00:50:48 -07:00
lisk/dao Plug the establishConnection() Lisk isolation hole 2011-05-01 08:05:02 -07:00
qsprintf Distinguish between aphront and phabricator. 2011-01-22 17:45:28 -08:00
queryfx Revert HipHop volatile symbol workaround. 2011-03-02 17:21:23 -08:00