1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-04-09 02:48:41 +02:00
phorge-phorge/src/applications/diffusion
epriestley 4dc857e36d Fix an issue with incorrect split head detection in Mercurial after pushing a medley of varied changes
Summary:
Fixes T10665. See that task for discussion.

Because `$head_map` is not properly re-initialized for each ref we check, pushes which affect multiple branches (say, "A" and "B") can have information bleed from the first branch check to the second branch.

To trigger a problem behavior, you can push one commit which updates an existing branch, plus one commit which creates a new branch. If they process in the right order, the `$head_map` from the updated branch will bleed into the `$head_map` for the new branch and trigger an incorrect head split detection.

Test Plan:
  - Pushed a set of changes which updated `branch-a` and created `branch-b`.
    - Before change: improper detection of split heads.
    - After change: clean push.
  - Pushed a set of changes which split the head of `branch-d`.
    - Correct detection of split heads.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10665

Differential Revision: https://secure.phabricator.com/D15522
2016-03-25 07:33:55 -07:00
..
application Support ID-based repository URIs, and canonicalize repository URIs 2016-02-18 09:56:28 -08:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
conduit Unbreak regex filename search 2016-03-20 10:15:21 -07:00
config Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
controller Only require view permissions for read-only Git LFS requests 2016-03-19 14:23:22 -07:00
data Parse and display commit authorship date in Git in Diffusion 2016-01-11 09:32:37 -08:00
doorkeeper Partially modernize Doorkeeper/Asana bridge 2014-10-01 07:09:34 -07:00
edge Fix reverting commit language 2015-06-01 09:54:30 +10:00
engine Fix an issue with incorrect split head detection in Mercurial after pushing a medley of varied changes 2016-03-25 07:33:55 -07:00
engineextension Move PhabricatorHovercard to PHUIHovercard 2016-02-03 16:26:30 +00:00
exception Replace AphrontUsageException with AphrontMalformedRequestException 2015-09-03 10:04:17 -07:00
garbagecollector Support ID-based repository URIs, and canonicalize repository URIs 2016-02-18 09:56:28 -08:00
gitlfs Implement a Git LFS link table and basic batch API 2016-03-17 17:15:20 -07:00
herald Move various other callsites away from callsigns 2016-01-04 06:54:42 -08:00
panel Add "Mailing List" users 2015-06-03 18:42:33 -07:00
protocol Added an intercept to Mercurial's capabilities command to remove bundle2. 2015-10-10 07:14:48 -07:00
query Allow diffusion.filecontentquery to load data for arbitrarily large files 2016-01-21 09:52:43 -08:00
remarkup Stop all object mentions from matching after "@" 2015-09-29 06:43:49 -07:00
request Remove uncalled DiffusionRequest->getCallsign() 2016-02-17 17:17:35 -08:00
response Implement a Git LFS server which supports no operations 2016-03-17 08:08:43 -07:00
ssh Make serving repositories work with alternate URIs 2016-02-18 10:06:03 -08:00
symbol Extend from Phobject 2015-06-15 18:02:27 +10:00
typeahead Improve type and icon information in typeahead 2016-02-05 12:48:20 -08:00
view Make dates/times more concise in Diffusion 2016-03-18 09:11:09 -07:00
DiffusionLintSaveRunner.php Move repository URIs to a dedicated index 2016-01-13 09:34:31 -08:00