revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-11 17:32:41 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications
History
epriestley 4c0ec01ce5 Allow Herald rules to add reviewers 
Summary:
Ref T1279. Although I think this is a bad idea in general (we once supported it, removed it, and seemed better off for it) users expect it to exist and want it to be available. Give them enough rope to shoot themselves in the foot.

I will probably write some lengthy treatise on how you shouldn't use this rule later.

Implementation is straightforward because Differential previously supported this rule.

This rule can also be used to add project reviewers.

Test Plan: Made some "add reviewers" rules, created revisions, saw reviewers trigger.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1279

Differential Revision: https://secure.phabricator.com/D7235
2013-10-05 14:10:51 -07:00
..
arcanist/conduit Move Conduit methods inside applications 2012-12-21 12:21:59 -08:00
audit Make most repository reads policy-aware 2013-09-25 16:54:48 -07:00
auth Fix issues with first-time account registration 2013-10-05 08:02:41 -07:00
base Tighten up some policy interactions in Herald 2013-10-04 15:15:48 -07:00
cache Provide 'bin/cache', for managing caches 2013-05-20 10:16:35 -07:00
calendar Move PHUIFormBoxView to PHUIObjectBoxView 2013-09-25 11:23:29 -07:00
chatlog Explain policy exception rules to users 2013-09-27 08:43:41 -07:00
conduit Explain policy exception rules to users 2013-09-27 08:43:41 -07:00
config Add a config setting for storing application settings 2013-10-03 12:39:30 -07:00
conpherence Explain policy exception rules to users 2013-09-27 08:43:41 -07:00
countdown Provide more structure to PHUIObjectBoxView 2013-09-30 09:36:04 -07:00
daemon Explain policy exception rules to users 2013-09-27 08:43:41 -07:00
differential Allow Herald rules to add reviewers 2013-10-05 14:10:51 -07:00
diffusion Split users apart from projects/packages in reviewer and audit UIs 2013-10-05 14:10:49 -07:00
directory/controller If a user can't see an application, prevent them from using its controllers 2013-10-03 12:39:41 -07:00
diviner Explain policy exception rules to users 2013-09-27 08:43:41 -07:00
doorkeeper Explain policy exception rules to users 2013-09-27 08:43:41 -07:00
draft/storage Add draft support to ApplicationTransactions 2012-12-21 05:57:14 -08:00
drydock Provide more structure to PHUIObjectBoxView 2013-09-30 09:36:04 -07:00
fact Convert AphrontTableView to safe HTML 2013-02-09 15:11:38 -08:00
feed Explain policy exception rules to users 2013-09-27 08:43:41 -07:00
files Make Herald rules obey policies during application 2013-10-05 12:55:34 -07:00
flag Flags - add ability to group by color 2013-10-01 15:06:35 -07:00
harbormaster Make most repository reads policy-aware 2013-09-25 16:54:48 -07:00
help/controller Make Differential views capability-sensitive 2013-09-26 18:45:04 -07:00
herald Allow Herald rules to add reviewers 2013-10-05 14:10:51 -07:00
legalpad Provide more structure to PHUIObjectBoxView 2013-09-30 09:36:04 -07:00
lipsum Kill PhabricatorObjectDataHandle 2013-09-11 12:27:28 -07:00
macro Make most file reads policy-aware 2013-09-30 09:38:13 -07:00
mailinglists Explain policy exception rules to users 2013-09-27 08:43:41 -07:00
maniphest lipsum - tighten up some test data generation 2013-10-04 15:29:32 -07:00
meta Prevent administrators from locking themselves out of applications 2013-10-04 15:13:58 -07:00
metamta Make most file reads policy-aware 2013-09-30 09:38:13 -07:00
notification Allow projects to review revisions 2013-10-05 14:10:46 -07:00
oauthserver Initialize used variable 2013-07-09 21:55:27 -07:00
owners Explain policy exception rules to users 2013-09-27 08:43:41 -07:00
paste Make most file reads policy-aware 2013-09-30 09:38:13 -07:00
people Make most file reads policy-aware 2013-09-30 09:38:13 -07:00
phame Provide more structure to PHUIObjectBoxView 2013-09-30 09:36:04 -07:00
phid Allow projects to review revisions 2013-10-05 14:10:46 -07:00
phlux Provide more structure to PHUIObjectBoxView 2013-09-30 09:36:04 -07:00
pholio lipsum - tighten up some test data generation 2013-10-04 15:29:32 -07:00
phortune Provide more structure to PHUIObjectBoxView 2013-09-30 09:36:04 -07:00
phpast Move PHUIFormBoxView to PHUIObjectBoxView 2013-09-25 11:23:29 -07:00
phrequent Add "Stop Tracking" link to entries in the Phrequent search view. 2013-10-01 13:17:28 -07:00
phriction Explain policy exception rules to users 2013-09-27 08:43:41 -07:00
policy Tighten up some policy interactions in Herald 2013-10-04 15:15:48 -07:00
ponder Provide more structure to PHUIObjectBoxView 2013-09-30 09:36:04 -07:00
project Allow projects to review revisions 2013-10-05 14:10:46 -07:00
releeph Provide more structure to PHUIObjectBoxView 2013-09-30 09:36:04 -07:00
remarkup/conduit Convert Remarkup to safe HTML 2013-02-13 12:34:49 -08:00
repository Split users apart from projects/packages in reviewer and audit UIs 2013-10-05 14:10:49 -07:00
search Accommodate project reviewers in Differential search 2013-10-05 14:10:47 -07:00
settings Move "unlisted" apps to Query, use Query for app preferences 2013-10-04 06:46:47 -07:00
slowvote Provide more structure to PHUIObjectBoxView 2013-09-30 09:36:04 -07:00
subscriptions Kill PhabricatorObjectDataHandle 2013-09-11 12:27:28 -07:00
system Add a user-accessible hook for dumping debug code into an install 2013-03-04 13:45:51 -08:00
tokens Explain policy exception rules to users 2013-09-27 08:43:41 -07:00
transactions Write "attach" edges when files are attached to objects via comment or other transactions 2013-10-01 16:15:07 -07:00
typeahead Accommodate project reviewers in Differential search 2013-10-05 14:10:47 -07:00
uiexample Allow transactions to be grouped in the TimelineView 2013-09-24 14:35:35 -07:00
xhprof Make most file reads policy-aware 2013-09-30 09:38:13 -07:00