1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-30 18:52:42 +01:00
phorge-phorge/src/applications/pholio
epriestley c125ab7a42 Remove "metamta.*.subject-prefix" options
Summary:
In ~2012, the first of these options was added because someone who hates dogs and works at Asana also hated `[Differential]` in the subject line. The use case there was actually //removing// the text, not changing it, but I made the prefix editable since it seemed like slightly less of a one-off.

These options are among the dumbest and most useless config options we have and very rarely used, see T11760. A very small number of instances have configured one of these options.

Newer applications stopped providing these options and no one has complained.

You can get the same effect with `translation.override`. Although I'm not sure we'll keep that around forever, it's a reasonable replacement today. I'll call out an example in the changelog to help installs that want to preserve this option.

If we did want to provide this, it should just be in {nav Applications > Settings} for each application, but I think it's wildly-low-value and "hack via translations" or "local patch" are entirely reasonable if you really want to change these strings.

Test Plan: Grepped for `subject-prefix`.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D19993
2019-01-17 19:18:50 -08:00
..
application Revert the alternate menu names for applications 2018-04-08 10:20:24 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
controller Implement Pholio file add/remove transactions without "applyInitialEffects" 2018-12-28 00:02:55 -08:00
edge Modernize Pholio edges 2015-01-02 10:11:41 +11:00
editor Remove "metamta.*.subject-prefix" options 2019-01-17 19:18:50 -08:00
engine Reduce the amount of weird "static" and "cache" behavior in Pholio query classes 2018-12-20 15:32:13 -08:00
herald Make Herald test workflow modular and more clear 2016-08-03 16:12:33 -07:00
lipsum Make Images in Pholio refer to mocks by PHID instead of ID 2018-12-20 14:54:25 -08:00
mail Allow multiple mail receivers to react to an individual email 2019-01-16 12:28:02 -08:00
phid Make Images in Pholio refer to mocks by PHID instead of ID 2018-12-20 14:54:25 -08:00
query Reduce the amount of weird "static" and "cache" behavior in Pholio query classes 2018-12-20 15:32:13 -08:00
relationships Convert all standard relationship-editing actions to modern Relationships code 2016-06-29 11:24:52 -07:00
remarkup Fix an issue with {M13} and Spaces 2015-06-13 06:54:02 -07:00
search Support Ferret engine in Pholio 2017-09-07 13:25:29 -07:00
storage Restore a Mock key to Pholio Images 2018-12-28 00:03:48 -08:00
view Reduce the amount of weird "static" and "cache" behavior in Pholio query classes 2018-12-20 15:32:13 -08:00
xaction Implement Pholio file add/remove transactions without "applyInitialEffects" 2018-12-28 00:02:55 -08:00