1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-27 06:58:17 +01:00
phorge-phorge/webroot/rsrc/js/application
epriestley 2a355d8548 Make Diffusion "Last Modified" rendering less fragile
Summary:
Ref T9524. Because fetching the last time files were modified in Diffusion can be slow, we bring it in over Ajax.

The logic to fetch and paint the table is kind of fragile because there are two different definitions of the columns right now and we break in a bad way if they differ.

In particular, calling `diffusion.updatecoverage` can populate a "lint commit" for a repository, which tries to generate lint information in one of the views (but not the other one).

In the longer run I think we're removing some of the concepts here and this rendering should be rebuilt to not have two separate column definitions, but just make it degrade gracefully for now since those are larger changes.

Test Plan:
Reproduced the issue in T9524 by calling `diffusion.updatecoverage` on a repostiory. Specifically, this has a side effect of creating a "lint commit" which triggers a "lint" column in this table, sort of.

Applied this patch, got a clean render.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9524

Differential Revision: https://secure.phabricator.com/D14243
2015-10-07 07:32:27 -07:00
..
aphlict Merge branch 'master' into redesign-2015 2015-06-22 15:52:40 -07:00
auth
calendar
config
conpherence Remove Files Widget from Conpherence 2015-08-20 08:24:42 -07:00
countdown
daemon Execute Maniphest batch edits in the background with a web UI progress bar 2015-06-23 13:36:16 -07:00
dashboard
differential Show users what's wrong when they try to edit an inline with an editor already open 2015-09-10 11:36:38 -07:00
diffusion Make Diffusion "Last Modified" rendering less fragile 2015-10-07 07:32:27 -07:00
doorkeeper
files
herald Make Herald action modularization more aggressive 2015-08-03 14:33:20 -07:00
maniphest [Redesign] Fix Maniphest subpriority editing 2015-06-30 09:37:12 -07:00
owners
passphrase
phame
pholio
phortune
policy
projects
releeph
repository Symbol Search: Allow ctrl-click with no hover 2015-08-27 04:17:38 -07:00
search
slowvote
transactions
typeahead
uiexample