1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-01 03:02:43 +01:00
phorge-phorge/src/applications/differential/xaction
epriestley 11c9994134 Allow "arc diff --plan-changes" to work with drafts enabled
Summary:
See PHI346. Ref T13054. If you have prototypes enabled on the server but use `master` / `stable` on the client and run `arc diff --plan-changes`, the transition is rejected because "Draft -> Changes Planned" isn't currently a legal transition.

Allow this transition if not coming from the web UI (to keep it out of the dropdown).

Test Plan:
  - Ran `arc diff --plan-changes` on `master`, got a "Changes Planned" revision instead of a validation error.
  - Ran `arc diff` without `--plan-changes`, got a draft, verified that "Plan Changes" still doesn't appear in the action dropdown.

Maniphest Tasks: T13054

Differential Revision: https://secure.phabricator.com/D19067
2018-02-12 13:15:13 -08:00
..
DifferentialRevisionAbandonTransaction.php Align most revision actions to the new "Draft" state 2017-09-21 07:20:48 -07:00
DifferentialRevisionAcceptTransaction.php Disallow "Accept" on drafts, allow "Resign" 2017-11-28 13:46:26 -08:00
DifferentialRevisionActionTransaction.php Align most revision actions to the new "Draft" state 2017-09-21 07:20:48 -07:00
DifferentialRevisionCloseTransaction.php Align most revision actions to the new "Draft" state 2017-09-21 07:20:48 -07:00
DifferentialRevisionCommandeerTransaction.php Align most revision actions to the new "Draft" state 2017-09-21 07:20:48 -07:00
DifferentialRevisionHoldDraftTransaction.php Allow "arc diff --draft" to create revisions as drafts more forcefully 2017-11-14 12:30:47 -08:00
DifferentialRevisionInlineTransaction.php Add a missing (int) cast to diff IDs for new "transaction.search" method 2017-08-25 07:31:22 -07:00
DifferentialRevisionPlanChangesTransaction.php Allow "arc diff --plan-changes" to work with drafts enabled 2018-02-12 13:15:13 -08:00
DifferentialRevisionReclaimTransaction.php Align most revision actions to the new "Draft" state 2017-09-21 07:20:48 -07:00
DifferentialRevisionRejectTransaction.php Align most revision actions to the new "Draft" state 2017-09-21 07:20:48 -07:00
DifferentialRevisionReopenTransaction.php Align most revision actions to the new "Draft" state 2017-09-21 07:20:48 -07:00
DifferentialRevisionRepositoryTransaction.php Add Summary and Repository EditEngine fields + Modular Transactions to Differential 2016-12-13 18:18:32 -08:00
DifferentialRevisionRequestReviewTransaction.php Execute Herald again after promoting revisions out of the "Draft" state 2017-12-05 12:13:56 -08:00
DifferentialRevisionResignTransaction.php Disallow "Accept" on drafts, allow "Resign" 2017-11-28 13:46:26 -08:00
DifferentialRevisionReviewersTransaction.php Remove old reviewer double writes to legacy edge table in Differential 2017-08-11 13:38:52 -07:00
DifferentialRevisionReviewTransaction.php Remove old reviewer double writes to legacy edge table in Differential 2017-08-11 13:38:52 -07:00
DifferentialRevisionStatusTransaction.php Fill in some straightforward Maniphest transactions for transaction.search 2017-11-07 15:33:55 -08:00
DifferentialRevisionSummaryTransaction.php Fix two issues with embedding other fields inside "Summary" or "Test Plan" in Differential with the web UI 2017-01-25 13:07:30 -08:00
DifferentialRevisionTestPlanTransaction.php Move misplaced validation for ambiguous fields in "Test Plan" to the right place 2017-06-30 06:36:05 -07:00
DifferentialRevisionTitleTransaction.php Allow ModularTransactions to opt in to providing data to Conduit 2017-08-24 15:25:55 -07:00
DifferentialRevisionTransactionType.php Allow users to resign if they have authority over any reviewer 2017-03-24 13:14:47 -07:00
DifferentialRevisionVoidTransaction.php Don't downgrade accepts on update (fix "sticky accept") 2017-04-03 09:55:22 -07:00
DifferentialRevisionWrongStateTransaction.php Add an explicit warning in the Differential transaction log when users skip review 2017-11-30 11:03:55 -08:00