mirror of
https://we.phorge.it/source/phorge.git
synced 2024-09-23 02:38:48 +02:00
21f0aba701
Summary: The current approach of using a modal overlay dialog to create/edit inline comments is pretty silly. Use an inline textarea instead. This element isn't perfect and we have some mild modalness issues, but I think it's better than the silly thing we've got going on right now. We can keep poking it as people break it. Test Plan: - Created comments; submitted and undid them in empty and nonempty states. Used undo for nonempty states + cancel. - Edited comments; saved and canceled them. Used undo for changed state. - Replied to comments; yada yada as above. - Deleted comments. - Did various modal trickery where I clicked "Reply" on something else with a dialog already up, this very mildly glitches but I think it's not a big issue. Reviewers: vrana, btrahan, Makinde, nh Reviewed By: vrana CC: aran, epriestley Maniphest Tasks: T431 Differential Revision: https://secure.phabricator.com/D1716 |
||
|---|---|---|
| .. | ||
| addcomment | ||
| changesetdetailview | ||
| changesetlistview | ||
| difftableofcontents | ||
| inlinecomment | ||
| inlinecommentedit | ||
| localcommits | ||
| primarypane | ||
| revisioncomment | ||
| revisioncommentlist | ||
| revisiondetail | ||
| revisionlist | ||
| revisionstats | ||
| revisionupdatehistory | ||