mirror of
https://we.phorge.it/source/phorge.git
synced 2025-02-28 06:29:27 +01:00
9f5e6bee90
Summary: Depends on D20115. See <https://discourse.phabricator-community.org/t/transaction-search-endpoint-does-not-work-on-differential-diffs/2369/>. Currently, `getApplicationTransactionCommentObject()` throws by default. Subclasses must override it to `return null` to indicate that they don't support comments. This is silly, and leads to a bunch of code that does a `try / catch` around it, and at least some code (here, `transaction.search`) which doesn't `try / catch` and gets the wrong behavior as a result. Just make it `return null` by default, meaning "no support for comments". Then remove the `try / catch` stuff and all the `return null` implementations. Test Plan: - Grepped for `getApplicationTransactionCommentObject()`, fixed each callsite / definition. - Called `transaction.search` on a diff with transactions (i.e., not a sourced-from-commit diff). Reviewers: amckinley Reviewed By: amckinley Subscribers: jbrownEP Differential Revision: https://secure.phabricator.com/D20121
23 lines
608 B
PHP
23 lines
608 B
PHP
<?php
|
|
|
|
final class PhabricatorProfileMenuItemConfigurationTransaction
|
|
extends PhabricatorApplicationTransaction {
|
|
|
|
const TYPE_PROPERTY = 'profilepanel.property';
|
|
const TYPE_ORDER = 'profilepanel.order';
|
|
const TYPE_VISIBILITY = 'profilepanel.visibility';
|
|
|
|
public function getApplicationName() {
|
|
return 'search';
|
|
}
|
|
|
|
public function getTableName() {
|
|
// At least for now, this object uses an older table name.
|
|
return 'search_profilepanelconfigurationtransaction';
|
|
}
|
|
|
|
public function getApplicationTransactionType() {
|
|
return PhabricatorProfileMenuItemPHIDType::TYPECONST;
|
|
}
|
|
|
|
}
|