1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 01:32:42 +01:00
phorge-phorge/src/applications/ponder
epriestley 4d68c0ae04 Make Herald test workflow modular and more clear
Summary:
Fixes T9719. Currently, the Herald "Test Console" has a big `instanceof` thing, so new adapters (like a Calendar adapter, or third-party adapters) aren't available automatically. Instead, do a standard modular thing: load the available adapters, ask which ones can test the object the user selected, then let the user pick which one they want to move forward with.

Additionally, it isn't very clear that you can't test "commit hook" rules because they rely on push state which we don't really have a good way to simulate. When the user picks a commit, we now show them the "Hook" events, but the options are disabled and explain why they can not be selected.

Test Plan:
 - Ran test rules for revisions, commits, mocks, tasks, wiki documents, questions, and outbound mail.
 - Plugged in a commit, got a more-helpful choice screen explaining why you do a test run of hook rules.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9719

Differential Revision: https://secure.phabricator.com/D16360
2016-08-03 16:12:33 -07:00
..
application Add Ponder Question mail create receiver 2016-06-08 14:48:20 -07:00
capability Add a default moderation policy to Ponder 2015-08-08 12:20:01 -07:00
constants Redesign PonderQuestionView 2016-02-23 17:20:07 -08:00
controller Consistently refer to 'Projects' as 'Tags' 2016-04-19 16:48:21 +00:00
editor Redesign PonderQuestionView 2016-02-23 17:20:07 -08:00
herald Make Herald test workflow modular and more clear 2016-08-03 16:12:33 -07:00
mail Add Ponder Question mail create receiver 2016-06-08 14:48:20 -07:00
phid Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
query Redesign PonderQuestionView 2016-02-23 17:20:07 -08:00
remarkup Remarkup - add a regex to blacklist what objects get link 2014-08-14 15:20:45 -07:00
search Convert all "DocumentIndexers" into "FulltextEngines" 2015-12-21 17:25:23 -08:00
storage Add Ponder Question mail create receiver 2016-06-08 14:48:20 -07:00
view Give AphrontTagView a getViewer(), deprecate getUser() 2016-03-06 09:27:38 -08:00