1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-29 02:02:41 +01:00
phorge-phorge/src/applications/differential/query
epriestley 4d86d51125 Prepare TransactionCommentQuery for extension
Summary:
Ref T2009. Ref T1460. The way Diffusion and Differential load inlines is horrible garbage right now:

  - Differential does an ad-hoc query to get the PHIDs, then does a real load to policy check.
  - Diffusion completely fakes things. In practice this is not a policy violation, but it's dangerous.

Make TransactionCommentQuery extensible so we can subclass it and get the query building correctly in the right Query layer.

Specifically, the Diffusion and Differential subclasses of this Query will add appropriate `withX()` methods to let us express the query in SQL.

Test Plan: Loaded, previewed, edited, and submitted inlines in Differential and Diffusion

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T2009, T1460

Differential Revision: https://secure.phabricator.com/D12026
2015-03-09 14:11:18 -07:00
..
DifferentialChangesetQuery.php Fix method visibility for PhabricatorPolicyAwareQuery subclasses 2015-01-14 07:01:16 +11:00
DifferentialDiffQuery.php Fix method visibility for PhabricatorPolicyAwareQuery subclasses 2015-01-14 07:01:16 +11:00
DifferentialHunkQuery.php Rename DifferentialHunk subclasses for consistency 2015-01-23 07:17:04 +11:00
DifferentialInlineCommentQuery.php Explicitly track inline comment reply threading 2015-03-09 10:26:50 -07:00
DifferentialRepositoryLookup.php Fix an issue with UUID query construction 2013-09-30 03:55:07 -07:00
DifferentialRevisionQuery.php Policy - clean up the deprecated diffusion.getcommits 2015-01-30 11:51:16 -08:00
DifferentialRevisionSearchEngine.php Have DifferentialRevisionListView return ObjectBoxView 2015-02-19 08:11:17 -08:00
DifferentialTransactionQuery.php Prepare TransactionCommentQuery for extension 2015-03-09 14:11:18 -07:00