mirror of
https://we.phorge.it/source/phorge.git
synced 2025-02-27 22:19:29 +01:00
Summary: This diff adds a copy button to every repo uri in the clone repo modal. I have made the button to select the text to a merely structural span before the input - it just shows the type of the repository uri. When you click inside the input, the entire uri will be selected. Also I have uncluttered the HTML structure. A table is not needed here, nothing a flex block can't handle. | Before | After | |-----------|-----------| | {F1360344} | {F1368592} | While at it, I have extended the used javascript copy behavior. First of all: `document.execCommand('copy')` [[ https://developer.mozilla.org/en-US/docs/Web/API/Document/execCommand | could stop working every moment in every browser ]]. The [[ https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Interact_with_the_clipboard | new clipboard API ]] is the way to go, so I have implemented it as the preferred method. The old method is kept as a fallback. And I have added a very nice feature: If defined, the behavior will now issue success or error notifications. See the changed UIExamples for that. To support the shrinking of JS code with async functions I have patched the JsShrink source. Test Plan: Go to a repository, hit the clone button and use the new copy button. You will see a shiny notification as a reward. Reviewers: O1 Blessed Committers, avivey, valerio.bozzolan Reviewed By: O1 Blessed Committers, avivey, valerio.bozzolan Subscribers: avivey, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25536 |
||
---|---|---|
.. | ||
darkconsole | ||
behavior-audio-source.js | ||
behavior-autofocus.js | ||
behavior-badge-view.js | ||
behavior-bulk-editor.js | ||
behavior-choose-control.js | ||
behavior-copy.js | ||
behavior-detect-timezone.js | ||
behavior-device.js | ||
behavior-drag-and-drop-textarea.js | ||
behavior-fancy-datepicker.js | ||
behavior-form.js | ||
behavior-gesture.js | ||
behavior-global-drag-and-drop.js | ||
behavior-high-security-warning.js | ||
behavior-history-install.js | ||
behavior-hovercard.js | ||
behavior-keyboard-pager.js | ||
behavior-keyboard-shortcuts.js | ||
behavior-lightbox-attachments.js | ||
behavior-line-linker.js | ||
behavior-linked-container.js | ||
behavior-more.js | ||
behavior-object-selector.js | ||
behavior-oncopy.js | ||
behavior-phabricator-remarkup-assist.js | ||
behavior-read-only-warning.js | ||
behavior-redirect.js | ||
behavior-refresh-csrf.js | ||
behavior-remarkup-load-image.js | ||
behavior-remarkup-preview.js | ||
behavior-reorder-applications.js | ||
behavior-reveal-content.js | ||
behavior-scrollbar.js | ||
behavior-search-typeahead.js | ||
behavior-select-content.js | ||
behavior-select-on-click.js | ||
behavior-setup-check-https.js | ||
behavior-time-typeahead.js | ||
behavior-toggle-class.js | ||
behavior-tokenizer.js | ||
behavior-tooltip.js | ||
behavior-user-menu.js | ||
behavior-watch-anchor.js | ||
behavior-workflow.js | ||
Busy.js | ||
DragAndDropFileUpload.js | ||
DraggableList.js | ||
Favicon.js | ||
FileUpload.js | ||
Hovercard.js | ||
HovercardList.js | ||
KeyboardShortcut.js | ||
KeyboardShortcutManager.js | ||
MultirowRowManager.js | ||
Notification.js | ||
phtize.js | ||
Prefab.js | ||
RemarkupMetadata.js | ||
ShapedRequest.js | ||
TextAreaUtils.js | ||
Title.js | ||
ToolTip.js |