1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 22:40:55 +01:00
phorge-phorge/src
epriestley 4f018488ae Restore Lisk transactional methods
Summary:
Restores a (simplified and improved) version of Lisk transactions.

This doesn't actually use transactions anywhere yet. DifferentialRevisionEditor
is the #1 (and only?) case where we have transaction problems right now, but
sticking save() inside a transaction unconditionally will leave us holding a
transaction open for like a million years while we run Herald rules, etc. I want
to do some refactoring there separately from this diff before making it
transactional.

NOTE: @jungejason / @nh, can one of you verify these unit tests pass on
HPHP/i/vm when you get a chance? I vaguely recall there was some problem with
(int)$resource. We can land this safely without verifying that, but should check
before we start using it anywhere.

Test Plan: Ran unit tests.

Reviewers: btrahan, nh, jungejason

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T605

Differential Revision: https://secure.phabricator.com/D1515
2012-01-31 12:07:34 -08:00
..
aphront Add basic edit history to herald rules 2012-01-30 11:52:44 -08:00
applications Owners -- kill tabs 2012-01-31 11:06:20 -08:00
docs Document configuration of external editor links 2012-01-30 15:56:42 -08:00
infrastructure Use setConcreteOnly() in Phabricator and only list/launch concrete Daemons 2012-01-25 11:50:59 -08:00
storage Restore Lisk transactional methods 2012-01-31 12:07:34 -08:00
view Add a Join / Leave button to Projects 2012-01-25 11:51:20 -08:00
__celerity_resource_map__.php Add basic edit history to herald rules 2012-01-30 11:52:44 -08:00
__phutil_library_init__.php Distinguish between aphront and phabricator. 2011-01-22 17:45:28 -08:00
__phutil_library_map__.php Restore Lisk transactional methods 2012-01-31 12:07:34 -08:00