mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-10 17:02:41 +01:00
4f018488ae
Summary: Restores a (simplified and improved) version of Lisk transactions. This doesn't actually use transactions anywhere yet. DifferentialRevisionEditor is the #1 (and only?) case where we have transaction problems right now, but sticking save() inside a transaction unconditionally will leave us holding a transaction open for like a million years while we run Herald rules, etc. I want to do some refactoring there separately from this diff before making it transactional. NOTE: @jungejason / @nh, can one of you verify these unit tests pass on HPHP/i/vm when you get a chance? I vaguely recall there was some problem with (int)$resource. We can land this safely without verifying that, but should check before we start using it anywhere. Test Plan: Ran unit tests. Reviewers: btrahan, nh, jungejason Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T605 Differential Revision: https://secure.phabricator.com/D1515 |
||
---|---|---|
.. | ||
aphront | ||
applications | ||
docs | ||
infrastructure | ||
storage | ||
view | ||
__celerity_resource_map__.php | ||
__phutil_library_init__.php | ||
__phutil_library_map__.php |