1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 06:20:56 +01:00
phorge-phorge/src/applications/differential/view
epriestley 4fd4ec3d27 Hide inlines one-by-one, instead of in a big group
Summary:
Ref T12616. Fixes T12153. Currently, when you hide inlines, they hide completely and turn into a little bubble on the previous line.

Instead, collapse them to a single line one-by-one. Narrowly, this fixes T12153.

In the future, I plan to make these changes so this feature makes more sense:

  - Introduce global "hide everything" states (T8909) so you can completely hide stuff if you want, and this represents more of a halfway state between "nuke it" and "view it".
  - Make the actual rendering better, so it says "epriestley: blah blah..." instead of just "..." -- and looks less dumb.

The real goal here is to introduce `DiffInline` and continue moving stuff from the tangled jungle of a million top-level behaviors to sensible smooth statefulness.

Test Plan:
  - Hid and revealed inlines in unified and two-up modes.
  - These look pretty junk for now:

{F4948659}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12616, T12153

Differential Revision: https://secure.phabricator.com/D17861
2017-05-16 06:19:56 -07:00
..
DifferentialChangesetDetailView.php Hide inlines one-by-one, instead of in a big group 2017-05-16 06:19:56 -07:00
DifferentialChangesetFileTreeSideNavBuilder.php Convert all calls to 'IconFont' to just 'Icon' 2016-01-27 20:59:27 -08:00
DifferentialChangesetListView.php Hide inlines one-by-one, instead of in a big group 2017-05-16 06:19:56 -07:00
DifferentialLocalCommitsView.php Merge "Table of Contents", "Local Commits", "Update History" and "Similar Revisions" 2016-06-30 18:50:52 -07:00
DifferentialReviewersView.php When a package or project has been accepted or rejected, show who did it ("Accepted (by dog)") 2017-04-20 13:07:08 -07:00
DifferentialRevisionListView.php Fix some error log issues with uninitialized commit/revision lists 2017-05-14 13:28:02 -07:00
DifferentialRevisionUpdateHistoryView.php Show broken units in revision history 2016-09-02 10:29:29 -07:00
DifferentialTransactionView.php Make inline comment preview and submission mostly work on EditEngine 2016-12-31 10:10:29 -08:00