1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 17:02:41 +01:00
phorge-phorge/src
epriestley 5058cfb972 Pass a real viewer to HeraldAdapter when doing test console runs
Summary:
Depends on D18932. Ref T13048. See PHI276. In the cluster, we don't have device keys on `web` nodes. This is generally good, since they don't need them, and it means that we aren't putting more credentials than we need on those hosts.

However, it means that when we pull diff content to test "Commit" rules via the Herald test console, we use the omnipotent user and try to use device credentials, and this fails since we don't have any.

Instead, pass the real viewer in this case so we just sign the request as them, like we do for normal Diffusion requests.

Test Plan:
Wrote and ran a commit content rule locally, no issues.

This isn't completely convincing since my local setup does have device credentials, but I'll double-check in production once this deploys.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13048

Differential Revision: https://secure.phabricator.com/D18933
2018-01-26 11:08:12 -08:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Modularize rate/connection limits in Phabricator 2017-10-13 13:12:05 -07:00
applications Pass a real viewer to HeraldAdapter when doing test console runs 2018-01-26 11:08:12 -08:00
docs Document the new "only if this didn't match last time" Herald action setting 2018-01-26 11:06:43 -08:00
extensions Add src/extensions/ to Phabricator 2013-08-14 15:38:06 -07:00
infrastructure Fix failure to record pullerPHID in repository pull logs 2018-01-23 14:09:42 -08:00
view Allow bulk edits to be made silently if you have CLI access 2018-01-19 13:24:54 -08:00
__phutil_library_init__.php
__phutil_library_map__.php Mark the "Reviewer" field for Commits as deprecated 2018-01-26 11:07:02 -08:00