1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 01:32:42 +01:00
phorge-phorge/src/view/control
epriestley 51c4b199d0 Allow policy-aware queries to prefilter results
Summary:
Provides a simple way for policy-aware queries to pre-filter results without needing to maintain separate cursors, and fixes a bunch of filter-related edge cases.

  - For reverse-paged cursor queries, we previously reversed each individual set of results. If the final result set is built out of multiple pages, it's in the wrong order overall, with each page in the correct order in sequence. Instead, reverse everything at the end. This also simplifies construction of queries.
  - `AphrontCursorPagerView` would always render a "<< First" link when paging backward, even if we were on the first page of results.
  - Add a filtering hook to let queries perform in-application pre-policy filtering as simply as possible (i.e., without maintaing their own cursors over the result sets).

Test Plan: Made feed randomly prefilter half the results, and paged forward and backward. Observed correct result ordering, pagination, and next/previous links.

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D3787
2012-10-23 12:01:11 -07:00
..
AphrontAttachedFileView.php Move files in Phabricator one level up 2012-06-01 12:32:44 -07:00
AphrontCursorPagerView.php Allow policy-aware queries to prefilter results 2012-10-23 12:01:11 -07:00
AphrontPagerView.php Move files in Phabricator one level up 2012-06-01 12:32:44 -07:00
AphrontTableView.php Highlight update time in revision list 2012-08-20 17:59:13 -07:00
AphrontTokenizerTemplateView.php Move files in Phabricator one level up 2012-06-01 12:32:44 -07:00
AphrontTypeaheadTemplateView.php Move files in Phabricator one level up 2012-06-01 12:32:44 -07:00
PhabricatorObjectListView.php Make project membership edits use transactions and PHIDs and not be awful 2012-08-07 11:57:38 -07:00
PhabricatorObjectSelectorDialog.php Move files in Phabricator one level up 2012-06-01 12:32:44 -07:00