mirror of
https://we.phorge.it/source/phorge.git
synced 2024-09-21 09:48:47 +02:00
f1222f956a
Summary: Fixes T8917. Prior to T2618, deleting inlines prompted users, then really deleted the rows. After T2618, we delete immediately and offer "Undo". However, some interactions with drafts were missed, and we were only clearing the "this revision has a draft" flag on one of the delete pathways (when you delete all the comment text, then save the comment). Make both the "Delete" action and the "Delete All Comment Text + Save" workflows do the same thing: mark the row as deleted, and clear any relevant drafts. Test Plan: - Made an inline comment on a clean revision with no "draft comments" marker in the list view. - Used "delete" to delete it. - After applying the patch, verified that no "draft commetns" marker appears in the list view. - Used Delete and Edit + Remove Text + Save to delete comments in Differential and Diffusion. Reviewers: btrahan, chad Reviewed By: chad Subscribers: epriestley Maniphest Tasks: T8917 Differential Revision: https://secure.phabricator.com/D13665 |
||
|---|---|---|
| .. | ||
| interface | ||
| query | ||
| view | ||
| PhabricatorChangesetResponse.php | ||
| PhabricatorDifferenceEngine.php | ||
| PhabricatorInlineCommentController.php | ||
| PhabricatorInlineCommentPreviewController.php | ||