1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 17:52:43 +01:00
phorge-phorge/src/applications/files
epriestley 402d2e2605 When deleting a file, delete all transformations of the file
Summary:
Fixes T3143. When a user deletes a file, delete all transforms of the file too. In particular, this means that deleting an image deletes all the thumbnails of the image.

In most cases, this aligns with user expectations. The only sort of weird case I can come up with is that memes are transformations of the source macro image, so deleting grumpycat will delete all the hilarious grumpycat memes. This seems not-too-unreasonable, though, and desirable if someone accidentally uploads an inappropriate image which is promptly turned into a meme.

Test Plan:
Added a unit test which covers both inbound and outbound transformations.

Uploaded a file and deleted it, verified its thumbnail was also deleted.

Reviewers: chad, btrahan, joseph.kampf

Reviewed By: btrahan

CC: aran, joseph.kampf

Maniphest Tasks: T3143

Differential Revision: https://secure.phabricator.com/D5879
2013-05-09 16:08:35 -07:00
..
application Installation & Uninstallion of Applications 2013-01-29 09:17:24 -08:00
conduit Uninstall Conduit calls when uninstalling applications 2013-03-13 07:09:05 -07:00
config Conpherence - make the files widget purdy-ish 2013-03-15 23:41:36 -07:00
controller Add actions to mobile crumbs 2013-04-10 13:08:36 -07:00
engine Document where Arcanist configuration can be set 2013-04-20 11:44:29 -07:00
engineselector Delete license headers from files 2012-11-05 11:16:51 -08:00
exception Delete license headers from files 2012-11-05 11:16:51 -08:00
lipsum Made Changes to Mock and File generation after pushing some methods to superclass 2013-05-06 13:32:01 -07:00
management Apply lint rules to Phabricator 2013-02-19 13:33:10 -08:00
query When deleting a file, delete all transformations of the file 2013-05-09 16:08:35 -07:00
remarkup Implement text mode for Phabricator Remarkup rules 2013-03-22 17:33:36 -07:00
storage When deleting a file, delete all transformations of the file 2013-05-09 16:08:35 -07:00
view Convert phutil_render_tag(X, Y, pht('...')) to phutil_tag 2013-01-24 19:20:30 -08:00
PhabricatorImageTransformer.php Support animated gif in meme 2013-05-03 16:22:48 -07:00