mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-04 04:32:43 +01:00
541d794c13
Summary: Depends on D20111. Ref T6703. Currently, each ExternalAccount row is tied to a provider by `providerType` + `providerDomain`. This effectively prevents multiple providers of the same type, since, e.g., two LDAP providers may be on different ports on the same domain. The `domain` also isn't really a useful idea anyway because you can move which hostname an LDAP server is on, and LDAP actually uses the value `self` in all cases. Yeah, yikes. Instead, just bind each account to a particular provider. Then we can have an LDAP "alice" on seven different servers on different ports on the same machine and they can all move around and we'll still have a consistent, cohesive view of the world. (On its own, this creates some issues with the link/unlink/refresh flows. Those will be updated in followups, and doing this change in a way with no intermediate breaks would require fixing them to use IDs to reference providerType/providerDomain, then fixing this, then undoing the first fix most of the way.) Test Plan: Ran migrations, sanity-checked database. See followup changes for more comprehensive testing. Reviewers: amckinley Reviewed By: amckinley Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam Maniphest Tasks: T6703 Differential Revision: https://secure.phabricator.com/D20112
191 lines
4.9 KiB
PHP
191 lines
4.9 KiB
PHP
<?php
|
|
|
|
/**
|
|
* NOTE: When loading ExternalAccounts for use in an authentication context
|
|
* (that is, you're going to act as the account or link identities or anything
|
|
* like that) you should require CAN_EDIT capability even if you aren't actually
|
|
* editing the ExternalAccount.
|
|
*
|
|
* ExternalAccounts have a permissive CAN_VIEW policy (like users) because they
|
|
* interact directly with objects and can leave comments, sign documents, etc.
|
|
* However, CAN_EDIT is restricted to users who own the accounts.
|
|
*/
|
|
final class PhabricatorExternalAccountQuery
|
|
extends PhabricatorCursorPagedPolicyAwareQuery {
|
|
|
|
private $ids;
|
|
private $phids;
|
|
private $accountTypes;
|
|
private $accountDomains;
|
|
private $accountIDs;
|
|
private $userPHIDs;
|
|
private $needImages;
|
|
private $accountSecrets;
|
|
|
|
public function withUserPHIDs(array $user_phids) {
|
|
$this->userPHIDs = $user_phids;
|
|
return $this;
|
|
}
|
|
|
|
public function withAccountIDs(array $account_ids) {
|
|
$this->accountIDs = $account_ids;
|
|
return $this;
|
|
}
|
|
|
|
public function withAccountDomains(array $account_domains) {
|
|
$this->accountDomains = $account_domains;
|
|
return $this;
|
|
}
|
|
|
|
public function withAccountTypes(array $account_types) {
|
|
$this->accountTypes = $account_types;
|
|
return $this;
|
|
}
|
|
|
|
public function withPHIDs(array $phids) {
|
|
$this->phids = $phids;
|
|
return $this;
|
|
}
|
|
|
|
public function withIDs($ids) {
|
|
$this->ids = $ids;
|
|
return $this;
|
|
}
|
|
|
|
public function withAccountSecrets(array $secrets) {
|
|
$this->accountSecrets = $secrets;
|
|
return $this;
|
|
}
|
|
|
|
public function needImages($need) {
|
|
$this->needImages = $need;
|
|
return $this;
|
|
}
|
|
|
|
public function newResultObject() {
|
|
return new PhabricatorExternalAccount();
|
|
}
|
|
|
|
protected function loadPage() {
|
|
return $this->loadStandardPage($this->newResultObject());
|
|
}
|
|
|
|
protected function willFilterPage(array $accounts) {
|
|
$viewer = $this->getViewer();
|
|
|
|
$configs = id(new PhabricatorAuthProviderConfigQuery())
|
|
->setViewer($viewer)
|
|
->withPHIDs(mpull($accounts, 'getProviderConfigPHID'))
|
|
->execute();
|
|
$configs = mpull($configs, null, 'getPHID');
|
|
|
|
foreach ($accounts as $key => $account) {
|
|
$config_phid = $account->getProviderConfigPHID();
|
|
$config = idx($configs, $config_phid);
|
|
|
|
if (!$config) {
|
|
unset($accounts[$key]);
|
|
continue;
|
|
}
|
|
|
|
$account->attachProviderConfig($config);
|
|
}
|
|
|
|
if ($this->needImages) {
|
|
$file_phids = mpull($accounts, 'getProfileImagePHID');
|
|
$file_phids = array_filter($file_phids);
|
|
|
|
if ($file_phids) {
|
|
// NOTE: We use the omnipotent viewer here because these files are
|
|
// usually created during registration and can't be associated with
|
|
// the correct policies, since the relevant user account does not exist
|
|
// yet. In effect, if you can see an ExternalAccount, you can see its
|
|
// profile image.
|
|
$files = id(new PhabricatorFileQuery())
|
|
->setViewer(PhabricatorUser::getOmnipotentUser())
|
|
->withPHIDs($file_phids)
|
|
->execute();
|
|
$files = mpull($files, null, 'getPHID');
|
|
} else {
|
|
$files = array();
|
|
}
|
|
|
|
$default_file = null;
|
|
foreach ($accounts as $account) {
|
|
$image_phid = $account->getProfileImagePHID();
|
|
if ($image_phid && isset($files[$image_phid])) {
|
|
$account->attachProfileImageFile($files[$image_phid]);
|
|
} else {
|
|
if ($default_file === null) {
|
|
$default_file = PhabricatorFile::loadBuiltin(
|
|
$this->getViewer(),
|
|
'profile.png');
|
|
}
|
|
$account->attachProfileImageFile($default_file);
|
|
}
|
|
}
|
|
}
|
|
|
|
return $accounts;
|
|
}
|
|
|
|
protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
|
|
$where = parent::buildWhereClauseParts($conn);
|
|
|
|
if ($this->ids !== null) {
|
|
$where[] = qsprintf(
|
|
$conn,
|
|
'id IN (%Ld)',
|
|
$this->ids);
|
|
}
|
|
|
|
if ($this->phids !== null) {
|
|
$where[] = qsprintf(
|
|
$conn,
|
|
'phid IN (%Ls)',
|
|
$this->phids);
|
|
}
|
|
|
|
if ($this->accountTypes !== null) {
|
|
$where[] = qsprintf(
|
|
$conn,
|
|
'accountType IN (%Ls)',
|
|
$this->accountTypes);
|
|
}
|
|
|
|
if ($this->accountDomains !== null) {
|
|
$where[] = qsprintf(
|
|
$conn,
|
|
'accountDomain IN (%Ls)',
|
|
$this->accountDomains);
|
|
}
|
|
|
|
if ($this->accountIDs !== null) {
|
|
$where[] = qsprintf(
|
|
$conn,
|
|
'accountID IN (%Ls)',
|
|
$this->accountIDs);
|
|
}
|
|
|
|
if ($this->userPHIDs !== null) {
|
|
$where[] = qsprintf(
|
|
$conn,
|
|
'userPHID IN (%Ls)',
|
|
$this->userPHIDs);
|
|
}
|
|
|
|
if ($this->accountSecrets !== null) {
|
|
$where[] = qsprintf(
|
|
$conn,
|
|
'accountSecret IN (%Ls)',
|
|
$this->accountSecrets);
|
|
}
|
|
|
|
return $where;
|
|
}
|
|
|
|
public function getQueryApplicationClass() {
|
|
return 'PhabricatorPeopleApplication';
|
|
}
|
|
|
|
}
|