1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-27 09:12:41 +01:00
phorge-phorge/src
epriestley 553c335fbd Ignore unreachable commits when testing if a repository has imported
Summary:
Fixes T11309. When checking if a repository was fully imported, we incorrectly allow unreachable, un-imported commits to prevent the repository from moving to "Imported".

This can happen if you delete branches from a repository while it is importing.

Instead, ignore unreachable commits when checking for remaining imports, and when reporting status via `bin/repository importing`.

Test Plan:
  - Stopped daemons.
  - Created a new repository and activated it.
  - Ran `bin/repository update Rxx`.
  - Deleted a branch in the repository.
  - Ran `bin/repository update Rxx`.
  - Ran daemons to flush queue.

Now:

  - Ran `bin/repository importing`. Old behavior: showed unreachable commits as importing. New behavior: does not show unreachable commits.
  - Ran `bin/repository update`. Old behavior: failed to move repository to "imported" status. New behavior: correctly moves repository to "imported" status.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11309

Differential Revision: https://secure.phabricator.com/D16269
2016-07-11 09:23:08 -07:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Continue modernizing application access to user preferences 2016-06-04 14:37:56 -07:00
applications Ignore unreachable commits when testing if a repository has imported 2016-07-11 09:23:08 -07:00
docs Add a strong hint about importing or observing repositories to repository creation 2016-07-08 07:43:34 -07:00
extensions
infrastructure Make permanent worker failures more user-friendly 2016-07-11 09:21:39 -07:00
view Make "/" focus the search input again 2016-07-08 14:18:35 -07:00
__phutil_library_init__.php
__phutil_library_map__.php Use CommentEditEngine in PhamePost 2016-07-06 12:28:59 -07:00