epriestley 55a1ef339f Fix a bad method call signature throwing exceptions in newer Node ... Summary: Ref T13222. See PHI996. Ref T10743. For context, perhaps see T12171. Node changed some signatures, behaviors, and error handling here in recent versions. As far as I can tell: - The `script.runInNewContext(...)` method has never taken a `path` parameter, and passing the path has always been wrong. - The `script.runInNewContext(...)` method started taking an `[options]` parameter at some point, and validating it, so the bad `path` parameter now throws. - `vm.createScript(...)` is "soft deprecated" but basically fine, and keeping it looks more compatible. This seems like the smallest and most compatible correct change. Test Plan: Under Node 10, started Aphlict. Before: fatal error on bad `options` parameter to `runInNewContext()` (expected dictionary). After: notification server starts. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13222, T10743 Differential Revision: https://secure.phabricator.com/D19860		2018-12-10 16:01:00 -08:00
..
audio/basic	Add a few more sounds	2017-04-19 13:47:23 -07:00
css	Replace the "Choose Subtype" radio buttons dialog with a simpler "big stuff you click" sort of UI	2018-12-10 14:59:18 -08:00
externals	Fix a bad method call signature throwing exceptions in newer Node	2018-12-10 16:01:00 -08:00
favicons	Dynamically composite favicons from customizable sources	2018-03-12 15:28:41 -07:00
image	Uh, update Phabricator login image	2017-08-11 13:37:26 -07:00
js	Replace the "Choose Subtype" radio buttons dialog with a simpler "big stuff you click" sort of UI	2018-12-10 14:59:18 -08:00