1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-16 02:20:54 +01:00
phorge-phorge/webroot/rsrc/js/application/diff
epriestley 3700bcb638 Warn and prevent 1-up/2-up switch in Differential if the user is editing an inline
Summary:
See PHI180. Currently, if you begin creating or editing an inline and then swap display modes (for example, with "View Unified"), your edit is lost.

Persisting the editor state is complicated and this is very rare, so just prevent the action and warn the user instead.

Also make the warning persist for a little longer since a few of the messages, including this one, take a couple seconds to read now.

Test Plan:
  - Edited a comment, tried to swap display modes, got a warning.
  - Swapped display modes normally with no comment being edited.

Reviewers: amckinley

Reviewed By: amckinley

Differential Revision: https://secure.phabricator.com/D18774
2017-11-15 10:02:48 -08:00
..
behavior-preview-link.js Make "View" links on Differential inline comment previews work again 2017-01-02 13:24:02 -08:00
DiffChangeset.js Add options for hidding inlines to the Differential header banner 2017-06-15 05:23:14 -07:00
DiffChangesetList.js Warn and prevent 1-up/2-up switch in Differential if the user is editing an inline 2017-11-15 10:02:48 -08:00
DiffInline.js Fix an issue when deleting the entire content of an unsubmitted inline comment 2017-07-21 08:35:01 -07:00