1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-21 17:58:47 +02:00
phorge-phorge/src/applications/differential
epriestley 56a9709008 Reduce code duplication for inline "Undo"
Summary:
Ref T2009. This is another almost-identical copy of the row scaffolding, which has the same 1up/2up bugs as the 8 other copies of this code.

Turn the "undo" element into an InlineCommentView so we can scaffold it.

Then, scaffold it with the same code as everything else.

Test Plan: Hit "Undo", swapped from 1up to 2up, hit "undo" again, swapped back, tried left/right, everything rendered with proper scaffolding.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T2009

Differential Revision: https://secure.phabricator.com/D12019
2015-03-09 10:26:53 -07:00
..
__tests__ Further improve line grouping in unified views 2015-03-06 09:58:26 -08:00
application Remove getIconName from all applications 2015-01-30 12:11:21 -08:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
conduit Differential - add ability to setup "create" addresses for revisions 2015-01-30 10:31:39 -08:00
config Lock all reply-handler options in the upstream, plus cookie prefix 2015-02-13 11:00:09 -08:00
constants Differential - label unit / lint results from the commit diff as not applicable 2014-09-16 12:11:54 -07:00
controller Reduce code duplication for inline "Undo" 2015-03-09 10:26:53 -07:00
customfield Fix visibility for DifferentialManiphestTasksField::readValueFromRevision 2015-01-14 07:04:36 +11:00
doorkeeper Partially modernize Doorkeeper/Asana bridge 2014-10-01 07:09:34 -07:00
edge Don't write inverse edges for DifferentialRevisionHasReviewerEdgeType 2015-01-04 10:07:56 +11:00
editor Don't create mentions for dependent diffs 2015-01-23 07:12:05 +11:00
event Fix pht method calls 2015-02-10 18:57:45 +11:00
exception Remove an unused class 2015-01-03 09:07:32 +11:00
garbagecollector Complete modularization of the GC daemon 2014-01-15 10:02:31 -08:00
landing Explicitly declare method/property visibility 2015-01-12 08:18:13 +11:00
lipsum Remove an unused variable 2015-01-03 10:31:46 +11:00
mail MetaMTA - update documentation and make config a tad easier 2015-02-12 11:05:39 -08:00
management Rename DifferentialHunk subclasses for consistency 2015-01-23 07:17:04 +11:00
parser Use ChangesetListView on Differential standalone view 2015-03-09 10:26:47 -07:00
phid Rename PHIDType classes 2014-07-24 08:05:46 +10:00
query Explicitly track inline comment reply threading 2015-03-09 10:26:50 -07:00
remarkup Rename PhutilRemarkupRule subclasses 2014-08-05 00:55:43 +10:00
render Reduce code duplication for inline "Undo" 2015-03-09 10:26:53 -07:00
search Rename PHIDType classes 2014-07-24 08:05:46 +10:00
storage Explicitly track inline comment reply threading 2015-03-09 10:26:50 -07:00
view Reduce code duplication for inline "Undo" 2015-03-09 10:26:53 -07:00
DifferentialGetWorkingCopy.php Applied various linter fixes. 2014-06-09 16:04:12 -07:00