revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-03 12:12:43 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/diffusion/herald
History
epriestley 56f5c2443b Consolidate readers of "differential.revisionID" property 
Summary:
Depends on D20467. Ref T13277. Currently, the "MessageParserWorker" writes this property on commits, then Herald and Audit both read it.

Make them share code so this property has one writer and one reader. This property isn't great, but at least now the badness is hidden.

Currently, we can't just use edges because they may not have been written yet. I am likely to just do this, soon:

  - Just write the edges (in "MessageParserWorker").
  - Hide the edges from mail.

However, we'll sort-of lose the "revisionMatchData" explanation thing if I do that. Maybe this is fine? But when commits match because hashes match, it legitimately isn't obvious.

For now, just reduce the amount of harm/badness here.

Test Plan:
  - Ran `bin/repository reparse --publish ...`.
  - Ran a Herald "Audit" rule using the "Accepted Differential revision" field.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13277

Differential Revision: https://secure.phabricator.com/D20468
2019-05-01 09:46:17 -07:00
..
DiffusionAuditorsAddAuditorsHeraldAction.php Index and show Owners packages affected by Herald rules 2019-04-17 12:17:30 -07:00
DiffusionAuditorsAddSelfHeraldAction.php Modularize the Diffusion "Add Auditors" Herald action 2015-08-03 14:33:27 -07:00
DiffusionAuditorsHeraldAction.php Explicitly decline to add commit authors as auditors from Herald 2017-02-23 15:19:23 -08:00
DiffusionBlockHeraldAction.php Fix some copy/paste slop with BLOCK actions in Herald transcripts 2015-08-04 07:32:19 -07:00
DiffusionChangeHeraldFieldGroup.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitAffectedFilesHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitAuditorsHeraldField.php Add an "Auditors" rule for Commits 2017-01-18 10:05:30 -08:00
DiffusionCommitAuthorHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionCommitAuthorProjectsHeraldField.php Add "Committer's projects" and "Author's projects" fields to Herald commit rules 2018-02-27 14:33:12 -08:00
DiffusionCommitAutocloseHeraldField.php Deprecate the "Commit is on autoclose/permanent branch" Herald "Commit" field 2019-04-18 05:32:45 -07:00
DiffusionCommitBranchesHeraldField.php When evaluating the "Branches" Herald field from the test console, use the current viewer 2018-02-27 14:37:36 -08:00
DiffusionCommitCommitterHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionCommitCommitterProjectsHeraldField.php Add "Committer's projects" and "Author's projects" fields to Herald commit rules 2018-02-27 14:33:12 -08:00
DiffusionCommitDiffContentAddedHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitDiffContentHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitDiffContentRemovedHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitDiffEnormousHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitHeraldFieldGroup.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitMergeHeraldField.php Add "Is merge commit?" to commit fields in Herald 2015-12-05 13:07:56 -08:00
DiffusionCommitMessageHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionCommitPackageAuditHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitPackageHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitPackageOwnerHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitRepositoryHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionCommitRepositoryProjectsHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionCommitReviewerHeraldField.php Mark the "Reviewer" field for Commits as deprecated 2018-01-26 11:07:02 -08:00
DiffusionCommitRevisionAcceptedHeraldField.php Convert straggling Herald rules to modern revision status constants 2017-08-11 17:22:05 -07:00
DiffusionCommitRevisionAcceptingReviewersHeraldField.php Add an "Accepting reviewers" Herald field for commits 2017-12-26 15:59:36 -08:00
DiffusionCommitRevisionHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitRevisionReviewersHeraldField.php Add an "Accepting reviewers" Herald field for commits 2017-12-26 15:59:36 -08:00
DiffusionCommitRevisionSubscribersHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentAffectedFilesHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentAuthorHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitContentAuthorProjectsHeraldField.php Add "Committer's projects" and "Author's projects" fields to Herald commit rules 2018-02-27 14:33:12 -08:00
DiffusionPreCommitContentAuthorRawHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionPreCommitContentBranchesHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionPreCommitContentCommitterHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitContentCommitterProjectsHeraldField.php Add "Committer's projects" and "Author's projects" fields to Herald commit rules 2018-02-27 14:33:12 -08:00
DiffusionPreCommitContentCommitterRawHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionPreCommitContentDiffContentAddedHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentDiffContentHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentDiffContentRemovedHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentDiffEnormousHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentMergeHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionPreCommitContentMessageHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionPreCommitContentPackageHeraldField.php Add Owners Package support for "Commit Hook: Content" Herald rules 2018-02-16 09:49:24 -08:00
DiffusionPreCommitContentPackageOwnerHeraldField.php Add Owners Package support for "Commit Hook: Content" Herald rules 2018-02-16 09:49:24 -08:00
DiffusionPreCommitContentPusherHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitContentPusherIsCommitterHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionPreCommitContentPusherProjectsHeraldField.php Add "Committer's projects" and "Author's projects" fields to Herald commit rules 2018-02-27 14:33:12 -08:00
DiffusionPreCommitContentRepositoryHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitContentRepositoryProjectsHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitContentRevisionAcceptedHeraldField.php Convert straggling Herald rules to modern revision status constants 2017-08-11 17:22:05 -07:00
DiffusionPreCommitContentRevisionAcceptingReviewersHeraldField.php Add an "Accepting reviewers" Herald field for commits 2017-12-26 15:59:36 -08:00
DiffusionPreCommitContentRevisionHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentRevisionReviewersHeraldField.php Add an "Accepting reviewers" Herald field for commits 2017-12-26 15:59:36 -08:00
DiffusionPreCommitContentRevisionSubscribersHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitRefChangeHeraldField.php Further modularize Herald values 2015-07-16 14:12:23 -07:00
DiffusionPreCommitRefHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitRefHeraldFieldGroup.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitRefNameHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionPreCommitRefPusherHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitRefPusherProjectsHeraldField.php Add "Committer's projects" and "Author's projects" fields to Herald commit rules 2018-02-27 14:33:12 -08:00
DiffusionPreCommitRefRepositoryHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitRefRepositoryProjectsHeraldField.php Add "Committer's projects" and "Author's projects" fields to Herald commit rules 2018-02-27 14:33:12 -08:00
DiffusionPreCommitRefTypeHeraldField.php Accept pushes with arbitrary Git refs 2019-04-17 12:43:20 -07:00
DiffusionPreCommitUsesGitLFSHeraldField.php Add a Herald pre-commit field for detecting LFS usage 2017-12-18 09:12:52 -08:00
HeraldCommitAdapter.php Consolidate readers of "differential.revisionID" property 2019-05-01 09:46:17 -07:00
HeraldPreCommitAdapter.php Prevent "Call webhooks" Herald action from appearing in UI for adapters which can't fire it 2018-02-11 06:15:29 -08:00
HeraldPreCommitContentAdapter.php Add Owners Package support for "Commit Hook: Content" Herald rules 2018-02-16 09:49:24 -08:00
HeraldPreCommitRefAdapter.php Further modularize Herald values 2015-07-16 14:12:23 -07:00