1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-28 17:52:43 +01:00
phorge-phorge/src/applications/pholio
epriestley 84020a363f Let Herald activation depend on which transactions are being applied, and generate transactions
Summary:
Ref T2222. Ref T4484. This is a stepping stone to getting Herald supported in the new Differental code. Generally:

  - Instead of an Editor either supporting or not supporting Herald, let it choose based on transactions. Specifically, Differential only runs rules on revision creation and diff updates.
  - Optionally, allow an Editor to return some transactions to apply instead of having to apply everything itself. This lets us make it clear why changes happend in the transaction log, and share more code.
  - I updated only one transaction type (owners in Maniphest) since it was the easiest and cleanest to update and test. Everything else still works like it used to, it just won't generate a transaction record yet.
  - The transaction records are a touch rough, but we can clean them up later.

Test Plan: {F122282}

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4484, T2222

Differential Revision: https://secure.phabricator.com/D8404
2014-03-05 12:06:59 -08:00
..
application Add app icons to quick menu 2014-01-31 15:19:39 -08:00
capability Add a defualt view policy for Pholio 2014-01-30 11:53:42 -08:00
config Pholio - support editing images - fixes T3489 2013-07-16 13:31:20 -07:00
constants Pholio - back end for image re-ordering 2013-08-12 13:09:07 -07:00
controller Pholio - robustify submission errors to retain image edits 2014-02-11 11:38:10 -08:00
editor Let Herald activation depend on which transactions are being applied, and generate transactions 2014-03-05 12:06:59 -08:00
event Various linter fixes. 2014-02-26 12:44:58 -08:00
lipsum lipsum - tighten up some test data generation 2013-10-04 15:29:32 -07:00
mail Pholio - support editing images - fixes T3489 2013-07-16 13:31:20 -07:00
phid Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
query Lock policy queries to their applications 2013-10-21 17:20:27 -07:00
remarkup Pholio - support editing images - fixes T3489 2013-07-16 13:31:20 -07:00
search Restore search indexing to Ponder questions 2013-07-29 12:04:19 -07:00
storage Allow CustomField to provide ApplicationTransaction change details 2014-02-21 11:53:04 -08:00
view Use timeline view in Differential and make inlines somewhat usable again 2014-02-13 15:00:29 -08:00