1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 08:42:41 +01:00
phorge-phorge/webroot/rsrc/js/phuix
Chad Little 020f3c729a Fix username typeahead in Remarkup with German keyboard layout
Summary:
Ref T10252. The previous fix rPa8a9fddb0738 only works for macOS.
Under Windows the @ symbol is composed of AltGr+q. For Chrome and Edge the "AltGr" keypressEvent is like pressing the Control key and the Alt key at the same time.
This fix changes the condition in such a way, that this case (pressing Control and Alt at the same time) is not blocked.

Test Plan:
Testing for the issue:

 - Launch Windows 10, Select German Keyboard, Use latest Chrome (60)
 - Observe typing `@` does not trigger typeahead
 - Apply patch, retest, see typeahead.

Regression tested:

 - Windows 10, Chrome, Firefox, Edge
 - Mac OS, Chrome, Firefox, Safari
 - Keyboard layouts, English, French, German, Spanish

All tests passed

Reviewers: benwick, epriestley

Reviewed By: epriestley

Subscribers: epriestley

Maniphest Tasks: T10252

Differential Revision: https://secure.phabricator.com/D18269
2017-08-03 10:46:32 -07:00
..
PHUIXActionListView.js Begin rebuilding dropdown menus on ActionList 2014-05-05 10:56:14 -07:00
PHUIXActionView.js Move "List Inline Comments" to the inline header dropdown menu 2017-06-15 07:11:30 -07:00
PHUIXAutocomplete.js Fix username typeahead in Remarkup with German keyboard layout 2017-08-03 10:46:32 -07:00
PHUIXButtonView.js Separate button CSS classes 2017-06-05 20:14:34 +00:00
PHUIXDropdownMenu.js Attempt to make dropdown item actions more consistent 2017-01-18 13:14:54 -08:00
PHUIXExample.js Add PHUIXButtonView and a UIExample 2017-05-30 18:01:16 -07:00
PHUIXFormControl.js When accepting revisions, allow users to accept on behalf of a subset of reviewers 2017-03-22 14:25:04 -07:00
PHUIXIconView.js Basic stacked action support for EditEngine 2015-12-03 12:32:02 -08:00