1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 03:12:41 +01:00
phorge-phorge/src/view/phui
epriestley 58f66fea80 Allow users to remove their own comments, and administrators to remove any comment
Summary:
Fixes T4909. Adds a "remove" link next to the edit link, which permanently hides a comment. Addresses two use cases:

  - Allowing administrators to clean up spam.
  - Allowing users to try to put the genie back in the bottle if they post passwords or sensitive links, etc.

The user who removed the comment is named in the removal text to enforce some level of administrative accountability.

No data is deleted, but there's currently no method to restore these comments. We'll see if we need one.

This is cheating a little bit by storing "removed" as "2" in the isDeleted field. This doesn't seem tooooo bad for now.

Test Plan:
  - Removed some of my comments.
  - As an administrator, removed other users' comments.
  - Failed to view history of a removed comment.
  - Failed to edit a removed comment.
  - Failed to remove a removed comment.
  - Verified feed doesn't show the old comment after comment removal.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: qgil, chad, epriestley

Maniphest Tasks: T4909

Differential Revision: https://secure.phabricator.com/D8945
2014-05-05 10:55:32 -07:00
..
calendar Add allday, multiday logic to AphrontEventView 2014-02-24 20:21:28 -08:00
PHUI.php PHUI Text View 2013-04-22 14:28:23 -07:00
PHUIBoxView.php Remove phui-box-inner 2014-02-19 23:05:42 -08:00
PHUIButtonBarView.php PHUIButtonBarView 2014-02-10 11:11:36 -08:00
PHUIButtonView.php Add a one-click "Scuttle Task" button to Maniphest 2014-03-25 14:20:25 -07:00
PHUIDocumentView.php Include Source Sans on-demand with Celerity 2014-03-06 11:39:48 -08:00
PHUIFeedStoryView.php Include storyText in feed POST data 2014-04-06 11:48:39 -07:00
PHUIHeaderView.php Modernize Calendar View 2014-02-16 09:25:29 -08:00
PHUIIconView.php Improve accessibility of some UI elements (forms, icons, timeline) 2014-05-05 08:16:35 -07:00
PHUIInfoPanelView.php PHUIInfoPanel 2013-10-25 11:09:06 -07:00
PHUIListItemView.php Document the aural attribute and __aural__ preview mode 2014-05-01 07:54:29 -07:00
PHUIListView.php PHUIListView Examples, CSS 2013-06-05 15:03:56 -07:00
PHUIObjectBoxView.php Use standard UI elements to render pull requests in Releeph 2014-04-18 06:44:45 -07:00
PHUIObjectItemListView.php Add Success/Fail states to PHUIObjectList 2014-04-29 10:14:18 -07:00
PHUIObjectItemView.php Add PHUIObjectItemView Status Display to Harbormaster 2014-04-29 11:10:16 -07:00
PHUIPinboardItemView.php Update pinboard view 2013-08-28 08:55:43 -07:00
PHUIPinboardView.php Update pinboard view styles, move to PHUI 2013-08-07 10:58:09 -07:00
PHUIPropertyGroupView.php PHUIPropertyListView 2013-10-11 07:53:56 -07:00
PHUIPropertyListView.php Add a Stacked view for PropertyList 2014-04-29 07:04:22 -07:00
PHUIRemarkupPreviewPanel.php Update Form Layouts 2013-08-26 11:53:11 -07:00
PHUIStatusItemView.php Split users apart from projects/packages in reviewer and audit UIs 2013-10-05 14:10:49 -07:00
PHUIStatusListView.php Record new commits in the push log 2013-12-05 11:59:41 -08:00
PHUITagView.php Remove setBarColor from PHUITagView 2014-01-14 14:18:52 -08:00
PHUITextView.php PHUI Text View 2013-04-22 14:28:23 -07:00
PHUITimelineEventView.php Allow users to remove their own comments, and administrators to remove any comment 2014-05-05 10:55:32 -07:00
PHUITimelineView.php End Cap for Timeline 2014-03-14 08:51:50 -07:00
PHUIWorkboardView.php Make Workboard and Workpanel views extend AphrontTagView 2014-01-13 12:23:39 -08:00
PHUIWorkpanelView.php Workboards - add task create + improve task placement wrt priority edits 2014-03-05 18:40:28 -08:00