1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 07:42:40 +01:00
phorge-phorge/src/applications/metamta
epriestley a8c9a5597d Improve error and header behaviors for Mailgun received mail webhook
Summary:
Ref T10709. Two issues:

  - If a user sends an invalid `!command`, we can throw, which means we don't return HTTP 200. This makes Mailgun re-send the mail later.
  - We don't parse headers of the modern API correctly, so the "Message-ID" failsafe doesn't work. Parse them correctly. I //believe// Mailgun's API changed at some point.

Test Plan:
This is difficult to test exhaustively in isolation. I used Mailgun's web tools to verify the format of the hook request, and faked some requests locally.

I'll keep an eye on this as it goes to production and make sure the fix is correct there.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10709

Differential Revision: https://secure.phabricator.com/D15575
2016-04-02 10:51:29 -07:00
..
action When we fail to process mail, tell the user about it 2014-04-03 18:43:18 -07:00
adapter Add amazon-ses.endpoint configuration 2016-03-23 12:28:59 -07:00
application Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
applicationpanel Update Meta for new UI 2016-04-01 14:13:16 -07:00
command Use PhutilClassMapQuery 2015-07-07 22:51:57 +10:00
constants Add basic support for Herald outbound rules 2015-08-15 10:54:33 -07:00
contentsource Modularize content sources 2016-03-26 11:59:45 -07:00
controller Improve error and header behaviors for Mailgun received mail webhook 2016-04-02 10:51:29 -07:00
edge MetaMTA - more progress towards a mail application 2015-06-23 11:37:14 -07:00
editor Use ApplicationTransactions in ApplicationEmail 2015-06-11 10:15:49 -07:00
exception Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
garbagecollector Provide bin/garbage for interacting with garbage collection 2015-10-02 09:17:24 -07:00
herald Various translation improvements 2015-11-03 07:02:46 +11:00
management variable days back for bin/mail volume 2015-08-27 04:40:45 -07:00
parser Extend from Phobject 2015-06-15 18:02:27 +10:00
phid Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
query Replace subscribe/unsubscribe for projects with explicit mail setting 2016-01-19 19:39:02 -08:00
receiver Improve lipsum generation of projects 2015-12-24 09:06:56 -08:00
replyhandler Stop moving "Cc" addresses to "To" when building mail targets 2016-03-12 07:30:00 -08:00
storage Modularize content sources 2016-03-26 11:59:45 -07:00
typeahead Remove mailing lists application 2015-06-03 18:42:36 -07:00
view HTML emails for Calendar event description changes should respect remarkup rules 2015-11-07 07:39:52 -08:00
PhabricatorMetaMTAWorker.php Consolidate outbound mail status in a new class 2015-08-14 04:31:42 -07:00