1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 08:12:40 +01:00
phorge-phorge/src/applications/pholio
epriestley 4d68c0ae04 Make Herald test workflow modular and more clear
Summary:
Fixes T9719. Currently, the Herald "Test Console" has a big `instanceof` thing, so new adapters (like a Calendar adapter, or third-party adapters) aren't available automatically. Instead, do a standard modular thing: load the available adapters, ask which ones can test the object the user selected, then let the user pick which one they want to move forward with.

Additionally, it isn't very clear that you can't test "commit hook" rules because they rely on push state which we don't really have a good way to simulate. When the user picks a commit, we now show them the "Hook" events, but the options are disabled and explain why they can not be selected.

Test Plan:
 - Ran test rules for revisions, commits, mocks, tasks, wiki documents, questions, and outbound mail.
 - Plugged in a commit, got a more-helpful choice screen explaining why you do a test run of hook rules.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9719

Differential Revision: https://secure.phabricator.com/D16360
2016-08-03 16:12:33 -07:00
..
application Modularize "related objects" menu items in Maniphest 2016-06-22 11:16:16 -07:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
config Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
controller Convert all standard relationship-editing actions to modern Relationships code 2016-06-29 11:24:52 -07:00
edge Modernize Pholio edges 2015-01-02 10:11:41 +11:00
editor Extract PHIDs from transactions later, fixing Paste extraction/attachment 2015-11-17 08:37:07 -08:00
herald Make Herald test workflow modular and more clear 2016-08-03 16:12:33 -07:00
lipsum Modularize content sources 2016-03-26 11:59:45 -07:00
mail phtize all the things 2015-05-22 21:16:39 +10:00
phid Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
query Don't include other users' unpublished drafts when counting Pholio inlines 2016-06-09 08:43:12 -07:00
relationships Convert all standard relationship-editing actions to modern Relationships code 2016-06-29 11:24:52 -07:00
remarkup Fix an issue with {M13} and Spaces 2015-06-13 06:54:02 -07:00
search Inch toward using ApplicationSearch to power related objects 2016-06-29 11:22:29 -07:00
storage Moderize Pholio UI 2016-04-01 12:29:32 -07:00
view Allow Pholio mocks to be created and edited without drag-and-drop 2016-06-09 08:43:38 -07:00