1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
phorge-phorge/webroot/rsrc
epriestley 5a604538ca Fix an initialization issue in Herald rules in Chrome
Summary:
Fixes T10646. When you load the page or click "New Condition" or "New Action", we try to add a condition and action with some default values.

Currently, the logic just sets everything to `null` or `'default'`. This technically works in Safari, but is less successful in Chrome. (I think Safari prevents you from picking an invalid value.)

Instead of relying on the browser to pick the right value, set the correct value explicitly.

Test Plan:
  - Created a new rule in Chrome, Safari.
  - Added fields and conditions in Chrome, Safari.
  - Edited existing rules in Chrome, Safari.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10646

Differential Revision: https://secure.phabricator.com/D15507
2016-03-22 09:13:51 -07:00
..
css Couple of Diffusion tweaks 2016-03-18 12:06:16 -07:00
externals Swap charts from gRaphael to D3 2016-02-01 10:36:59 -08:00
favicons Add mask-icon for Safari pinned tab 2015-11-22 13:04:06 -08:00
image Polish up timeline for PHIUTwoColumnView 2016-03-08 17:51:53 -08:00
js Fix an initialization issue in Herald rules in Chrome 2016-03-22 09:13:51 -07:00