revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-15 11:22:40 +01:00
Code Issues Releases Wiki Activity
phorge-phorge/src/applications/diffusion/herald
History
epriestley 0b1d6a3f6e Convert straggling Herald rules to modern revision status constants 
Summary:
Ref T2543. These are the last `ArcanistDifferentialRevisionStatus` callsites.

This removes the very old legacy `precommitRevisionStatus` field, which has no other readers. This was obsoleted by the `CLOSED_FROM_ACCEPTED` stuff, but retained for compatibility.

Test Plan:
  - Poked these with the test console, although they're a little tricky to be sure about.
  - Grepped for `ArcanistDifferentialRevisionStatus`, no more hits.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2543

Differential Revision: https://secure.phabricator.com/D18416
2017-08-11 17:22:05 -07:00
..
DiffusionAuditorsAddAuditorsHeraldAction.php Modularize the Diffusion "Add Auditors" Herald action 2015-08-03 14:33:27 -07:00
DiffusionAuditorsAddSelfHeraldAction.php Modularize the Diffusion "Add Auditors" Herald action 2015-08-03 14:33:27 -07:00
DiffusionAuditorsHeraldAction.php Explicitly decline to add commit authors as auditors from Herald 2017-02-23 15:19:23 -08:00
DiffusionBlockHeraldAction.php Fix some copy/paste slop with BLOCK actions in Herald transcripts 2015-08-04 07:32:19 -07:00
DiffusionChangeHeraldFieldGroup.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitAffectedFilesHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitAuditorsHeraldField.php Add an "Auditors" rule for Commits 2017-01-18 10:05:30 -08:00
DiffusionCommitAuthorHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionCommitAutocloseHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionCommitBranchesHeraldField.php Move various other callsites away from callsigns 2016-01-04 06:54:42 -08:00
DiffusionCommitCommitterHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionCommitDiffContentAddedHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitDiffContentHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitDiffContentRemovedHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitDiffEnormousHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitHeraldFieldGroup.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitMergeHeraldField.php Add "Is merge commit?" to commit fields in Herald 2015-12-05 13:07:56 -08:00
DiffusionCommitMessageHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionCommitPackageAuditHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitPackageHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitPackageOwnerHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitRepositoryHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionCommitRepositoryProjectsHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionCommitReviewerHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionCommitRevisionAcceptedHeraldField.php Convert straggling Herald rules to modern revision status constants 2017-08-11 17:22:05 -07:00
DiffusionCommitRevisionHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionCommitRevisionReviewersHeraldField.php Remove obsolete "relationships" code from Differential 2017-03-20 16:45:48 -07:00
DiffusionCommitRevisionSubscribersHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentAffectedFilesHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentAuthorHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitContentAuthorRawHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionPreCommitContentBranchesHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionPreCommitContentCommitterHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitContentCommitterRawHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionPreCommitContentDiffContentAddedHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentDiffContentHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentDiffContentRemovedHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentDiffEnormousHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentMergeHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionPreCommitContentMessageHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionPreCommitContentPusherHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitContentPusherIsCommitterHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionPreCommitContentPusherProjectsHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitContentRepositoryHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitContentRepositoryProjectsHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitContentRevisionAcceptedHeraldField.php Convert straggling Herald rules to modern revision status constants 2017-08-11 17:22:05 -07:00
DiffusionPreCommitContentRevisionHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitContentRevisionReviewersHeraldField.php Remove obsolete "relationships" code from Differential 2017-03-20 16:45:48 -07:00
DiffusionPreCommitContentRevisionSubscribersHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitRefChangeHeraldField.php Further modularize Herald values 2015-07-16 14:12:23 -07:00
DiffusionPreCommitRefHeraldField.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitRefHeraldFieldGroup.php Group and order Herald fields 2015-07-16 14:13:13 -07:00
DiffusionPreCommitRefNameHeraldField.php Reduce code duplication in Herald fields 2015-07-16 14:11:44 -07:00
DiffusionPreCommitRefPusherHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitRefPusherProjectsHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitRefRepositoryHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitRefRepositoryProjectsHeraldField.php Fully modularize Herald field values 2015-07-16 14:12:44 -07:00
DiffusionPreCommitRefTypeHeraldField.php Further modularize Herald values 2015-07-16 14:12:23 -07:00
HeraldCommitAdapter.php Rename "needReviewerStatus()" into "needReviewers()" 2017-03-20 16:46:16 -07:00
HeraldPreCommitAdapter.php Make Herald test workflow modular and more clear 2016-08-03 16:12:33 -07:00
HeraldPreCommitContentAdapter.php Rename "needReviewerStatus()" into "needReviewers()" 2017-03-20 16:46:16 -07:00
HeraldPreCommitRefAdapter.php Further modularize Herald values 2015-07-16 14:12:23 -07:00