epriestley d28ddc21a5 Don't error when trying to mirror or observe an empty repository ... Summary: Fixes T5965. Fixes two issues: - Observing an empty repository could write a warning to the log. - Mirroring an empty repository to a remote could fail. For observing: If newly-created with `git init --bare`, `git ls-remote` will return the empty string. Properly return an empty set of refs, rather than attempting to parse the single "line" that is produced by splitting that on newlines: ``` [2018-01-23 18:47:00] ERROR 8: Undefined offset: 1 at [/phab_path/phabricator/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php:405] arcanist(head=master, ref.master=5634f8410176), phabricator(head=master, ref.master=12551a1055ce), phutil(head=master, ref.master=4755785517cf) #0 PhabricatorRepositoryPullEngine::loadGitRemoteRefs(PhabricatorRepository) called at [<phabricator>/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php:343] #1 PhabricatorRepositoryPullEngine::executeGitUpdate() called at [<phabricator>/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php:126] #2 PhabricatorRepositoryPullEngine::pullRepositoryWithLock() called at [<phabricator>/src/applications/repository/engine/PhabricatorRepositoryPullEngine.php:40] #3 PhabricatorRepositoryPullEngine::pullRepository() called at [<phabricator>/src/applications/repository/management/PhabricatorRepositoryManagementUpdateWorkflow.php:59] ... ``` For mirroring: `git` treats `git push --mirror` specially when a repository is empty. Detect this case by seeing if `git for-each-ref --count 1` does anything. If the repository is empty, just bail. Test Plan: - Observed an empty and non-empty repository. - Mirrored an empty and non-empty repository. Reviewers: alexmv, amckinley Reviewed By: alexmv Subscribers: Korvin, epriestley Maniphest Tasks: T5965 Differential Revision: https://secure.phabricator.com/D18920		2018-01-24 15:50:30 -08:00
..
__tests__	Only load refs that are actual commits	2016-07-08 22:34:25 +00:00
PhabricatorRepositoryCommitRef.php	Extend from Phobject	2015-06-15 18:02:27 +10:00
PhabricatorRepositoryDiscoveryEngine.php	Fix spelling	2017-10-09 10:48:04 -07:00
PhabricatorRepositoryEngine.php	Censor credentials possibly present in Git remote URIs when pulls fail because of a URI mismatch	2017-07-31 09:43:01 -07:00
PhabricatorRepositoryMirrorEngine.php	Don't error when trying to mirror or observe an empty repository	2018-01-24 15:50:30 -08:00
PhabricatorRepositoryPullEngine.php	Don't error when trying to mirror or observe an empty repository	2018-01-24 15:50:30 -08:00
PhabricatorRepositoryRefEngine.php	Update major RefCursor callsites to work properly with RefPosition	2017-09-15 10:21:32 -07:00