1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-27 06:58:17 +01:00
phorge-phorge/src
epriestley 5b6d6c4fb3 Use repository identities, not denormalized strings, to identify authors for "Revision closed by commit X" stories
Summary:
Ref T12164. Ref T13276. Currently, the parsing pipeline copies the author and committer names and PHIDs into the transcaction record as metadata. They are then rendered directly from the metadata.

This makes planned changes to the parsing pipeline (to prevent races when multiple commits matching a single revision are pushed simultaneously) more difficult, and generally won't work with repository identities.

Instead, load the commit and use its identities.

Test Plan: Loaded a revision, saw the same story rendering for a "Closed by commit" story.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13276, T12164

Differential Revision: https://secure.phabricator.com/D20418
2019-04-17 12:24:49 -07:00
..
__tests__ Use PhutilClassMapQuery instead of PhutilSymbolLoader 2015-08-14 07:49:01 +10:00
aphront Refine the "Mangled Webserver Response" setup check 2019-03-05 12:58:32 -08:00
applications Use repository identities, not denormalized strings, to identify authors for "Revision closed by commit X" stories 2019-04-17 12:24:49 -07:00
docs Change docs to be consistent with script 2019-04-10 12:38:33 -07:00
extensions
infrastructure Reindex dashboards and panels (allow migrations to queue a job to queue other indexing jobs) 2019-04-17 12:05:49 -07:00
view Reduce drag-and-drop jank on dashboards 2019-04-17 12:20:44 -07:00
__phutil_library_init__.php
__phutil_library_map__.php Reindex dashboards and panels (allow migrations to queue a job to queue other indexing jobs) 2019-04-17 12:05:49 -07:00