1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-18 03:20:59 +01:00
phorge-phorge/src/applications/policy
Austin McKinley 9a0dd55442 Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults
Summary:
Fixes T13128. Ref PHI590. This is a rough-and-ready implementation of a new `PhabricatorPolicyCodex->compareToDefaultPolicy()` method that subclasses can override to handle special cases of policy defaults. Also implements a `PolicyCodex` for Phriction documents, because the default policy of a Phriction document is the policy of the root document.

I might break this change into two parts, one of which maintains the current behavior and another which implements `PhrictionDocumentPolicyCodex`.

Test Plan: Created some Phriction docs, fiddled with policies, observed expected colors in the header. Will test more comprehensively after review for basic reasonable-ness.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, swisspol

Maniphest Tasks: T13128

Differential Revision: https://secure.phabricator.com/D19409
2018-04-27 16:56:11 -07:00
..
__tests__ Remove empty implementations of describeAutomaticCapabilities() 2016-11-09 15:24:22 -08:00
application Allow different policy rules for different types of objects 2015-06-13 15:44:03 -07:00
capability Make "Can Interact" and logged-out users interact more gracefully 2017-03-09 08:50:57 -08:00
codex Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults 2018-04-27 16:56:11 -07:00
config Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
constants Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults 2018-04-27 16:56:11 -07:00
controller Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults 2018-04-27 16:56:11 -07:00
editor Fix an issue with editing pre-space objects using a form with no visibility controls 2016-02-18 11:15:40 -08:00
engineextension Allow *.search Conduit API methods to have data bulk-loaded by extensions 2016-07-31 11:15:18 -07:00
exception Modernize OAuthserver and provide more context on "no permission" exception 2015-09-03 10:05:23 -07:00
filter Fix spelling 2017-10-09 10:48:04 -07:00
interface Require several advanced postgraduate degrees to understand object policies 2016-11-09 15:05:38 -08:00
management Update "bin/policy show" to use PolicyCodex 2017-04-11 15:21:18 -07:00
phid Mark PhabricatorPHIDType::getPHIDTypeApplicationClass() as abstract 2015-11-03 06:47:12 +11:00
query Modernize "favorite project policies" setting 2016-06-04 14:42:11 -07:00
rule Fix flaky subscribers policy rule unit test 2016-12-11 12:27:57 -08:00
storage Extend PhabricatorPolicyCodex interface to handle "interesting" policy defaults 2018-04-27 16:56:11 -07:00
view Require several advanced postgraduate degrees to understand object policies 2016-11-09 15:05:38 -08:00