mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-29 02:02:41 +01:00
5cfc14cb43
Summary: Differential uses a byte-oriented linewrap algorithm. Instead, use a character-oriented one which will handle utf-8 properly. This implies a very slightly performance hit but we only run this code for lines which need to wrap, and the results get cached. It took about ~2.5ms for the test file on my machine. I'll keep an eye on it but I think it's currently a manageable cost. Test Plan: Diffed this file: https://secure.phabricator.com/P43 ...and got it to render like this: https://secure.phabricator.com/file/info/PHID-FILE-331ac241bede705b193b/ To do so, I had to disable the un-utf8 block which we can't actually do yet because of intraline diff, but it shows that once we can get rid of that it works completely correctly. It will "sort of" work in the meantime (nothing terrible happens). Reviewers: jungejason, aran, tuomaspelkonen CC: aran, epriestley Differential Revision: 513 |
||
---|---|---|
.. | ||
__init__.php | ||
DifferentialChangesetParser.php |