1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-10-24 01:28:52 +02:00
phorge-phorge/webroot/rsrc
epriestley dcf3ca8e04 When a user clicks a navigation link in a dialog, close the dialog
Summary:
Ref T13302. Currently, if you enable Quicksand (by clicking "Persistent Chat"), open a dialog with links in it (like "Create Subtask" with multiple available subtypes), and then follow a navigation link, the page content reloads behind the dialog but the dialog stays in the foreground.

Fix this by closing dialogs when users click navigation links inside them.

Test Plan:
With Quicksand enabled and disabled, clicked a subtask type in the "Create Subtask" dialog.

  - Before, Quicksand Disabled: Dialog stays on screen, then navigation occurs.
  - After, Quicksand Disabled: Dialog vanishes, then navigation occurs.
  - Before, Quicksand Enabled: Dialog stays on screen, navigation occurs behind it.
  - After, Quicksand Enabled: Dialog vanishes, then navigation occurs.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13302

Differential Revision: https://secure.phabricator.com/D20573
2019-06-18 15:16:32 -07:00
..
audio/basic Add a few more sounds 2017-04-19 13:47:23 -07:00
css Differentiate Remarkup header sizes more clearly 2019-06-04 16:03:32 -07:00
externals When a user clicks a navigation link in a dialog, close the dialog 2019-06-18 15:16:32 -07:00
favicons Dynamically composite favicons from customizable sources 2018-03-12 15:28:41 -07:00
image Render indent depth changes more clearly 2019-02-19 12:40:05 -08:00
js Provide chart function labels over the wire instead of making them up 2019-05-22 05:22:59 -07:00