mirror of
https://we.phorge.it/source/phorge.git
synced 2024-09-20 09:18:48 +02:00
187356fea5
Summary: Depends on D20140. Ref T13250. Currently, the top-level exception handler doesn't dump stacks because we might not be in debug mode, and we might double-extra-super fatal if we call `PhabricatorEnv:...` to try to figure out if we're in debug mode or not. We can get around this by setting a flag on the Sink once we're able to confirm that we're in debug mode. Then it's okay for the top-level error handler to show traces. There's still some small possibility that showing a trace could make us double-super-fatal since we have to call a little more code, but AphrontStackTraceView is pretty conservative about what it does and 99% of the time this is a huge improvement. Test Plan: {F6205122} Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13250 Differential Revision: https://secure.phabricator.com/D20142
53 lines
950 B
CSS
53 lines
950 B
CSS
/**
|
|
* @provides unhandled-exception-css
|
|
*/
|
|
|
|
.unhandled-exception-detail {
|
|
max-width: 760px;
|
|
margin: 24px auto;
|
|
background: #fff;
|
|
border: 1px solid #c0392b;
|
|
border-radius: 3px;
|
|
padding: 8px;
|
|
}
|
|
|
|
.unhandled-exception-detail .unhandled-exception-title {
|
|
color: #c0392b;
|
|
padding: 4px 8px 12px;
|
|
border-bottom: 1px solid #f4dddb;
|
|
font-size: 16px;
|
|
font-weight: 500;
|
|
margin: 0;
|
|
}
|
|
|
|
.unhandled-exception-detail .unhandled-exception-body {
|
|
padding: 16px 12px;
|
|
}
|
|
|
|
.unhandled-exception-with-stack {
|
|
max-width: 95%;
|
|
}
|
|
|
|
.unhandled-exception-stack {
|
|
background: #fcfcfc;
|
|
overflow-x: auto;
|
|
overflow-y: hidden;
|
|
}
|
|
|
|
.unhandled-exception-stack table {
|
|
border-spacing: 0;
|
|
border-collapse: collapse;
|
|
width: 100%;
|
|
border: 1px solid #d7d7d7;
|
|
}
|
|
|
|
.unhandled-exception-stack th {
|
|
background: #e7e7e7;
|
|
border-bottom: 1px solid #d7d7d7;
|
|
padding: 8px;
|
|
}
|
|
|
|
.unhandled-exception-stack td {
|
|
padding: 4px 8px;
|
|
white-space: nowrap;
|
|
}
|