1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-16 03:42:41 +01:00
phorge-phorge/src
epriestley 32d23254c9 Use --user and --password from bin/storage in PHP migrations
Summary:
Fixes T2059. Ref T2517.

Currently, you can run `bin/storage upgrade` with `--user` and `--password` arguments. However, these clownishly apply only to `.sql` patches -- the `.php` migrations still use the default user and password.

This is dumb. Stop doing it. Respect `--user` and `--password` for PHP patches.

(I implemented "override", which is very similar to "repair", but kept them separate since I think they're semantically distinct enough to differentiate.)

Test Plan: Ran `./bin/storage upgrade --user x --pass y --apply phabricator:20130219.commitsummarymig.php`. Verified the correct user and password were used both for the initial connect and patch application.

Reviewers: chad, vrana

Reviewed By: chad

CC: aran

Maniphest Tasks: T2059, T2517

Differential Revision: https://secure.phabricator.com/D5115
2013-02-25 22:20:23 -08:00
..
aphront Moving code off channel 2013-02-22 07:00:50 -08:00
applications Add "phabricator-remarkup" to transaction comments 2013-02-25 21:10:41 -08:00
docs Change URL for creating Facebook OAuth app 2013-02-23 09:07:10 -08:00
infrastructure Use --user and --password from bin/storage in PHP migrations 2013-02-25 22:20:23 -08:00
view Apply lint rules to Phabricator 2013-02-19 13:33:10 -08:00
__celerity_resource_map__.php Handle resizing nicely 2013-02-23 06:28:56 -08:00
__phutil_library_init__.php Delete license headers from files 2012-11-05 11:16:51 -08:00
__phutil_library_map__.php Moving code off channel 2013-02-22 07:00:50 -08:00