mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-15 19:32:40 +01:00
156b156e77
Summary: Ref T7803. Ref T5873. I want to drive Conduit through more shared infrastructure, but can't currently add parameters automatically. Put a `getX()` around the `defineX()` methods so the parent can provide default behaviors. Also like 60% of methods don't define any special error types; don't require them to implement this method. I want to move away from this in general. Test Plan: - Ran `arc unit --everything`. - Called `conduit.query`. - Browsed Conduit UI. Reviewers: btrahan Reviewed By: btrahan Subscribers: hach-que, epriestley Maniphest Tasks: T5873, T7803 Differential Revision: https://secure.phabricator.com/D12380
43 lines
1 KiB
PHP
43 lines
1 KiB
PHP
<?php
|
|
|
|
final class DifferentialQueryDiffsConduitAPIMethod
|
|
extends DifferentialConduitAPIMethod {
|
|
|
|
public function getAPIMethodName() {
|
|
return 'differential.querydiffs';
|
|
}
|
|
|
|
public function getMethodDescription() {
|
|
return pht('Query differential diffs which match certain criteria.');
|
|
}
|
|
|
|
protected function defineParamTypes() {
|
|
return array(
|
|
'ids' => 'optional list<uint>',
|
|
'revisionIDs' => 'optional list<uint>',
|
|
);
|
|
}
|
|
|
|
protected function defineReturnType() {
|
|
return 'list<dict>';
|
|
}
|
|
|
|
protected function execute(ConduitAPIRequest $request) {
|
|
$ids = $request->getValue('ids', array());
|
|
$revision_ids = $request->getValue('revisionIDs', array());
|
|
|
|
$diffs = array();
|
|
if ($ids || $revision_ids) {
|
|
$diffs = id(new DifferentialDiffQuery())
|
|
->setViewer($request->getUser())
|
|
->withIDs($ids)
|
|
->withRevisionIDs($revision_ids)
|
|
->needChangesets(true)
|
|
->needArcanistProjects(true)
|
|
->execute();
|
|
}
|
|
|
|
return mpull($diffs, 'getDiffDict', 'getID');
|
|
}
|
|
|
|
}
|