mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-29 10:12:41 +01:00
89a5d3132c
Summary:
This diff adds a copy button to every repo uri in the clone repo modal. I have made the button to select the text to a merely structural span before the input - it just shows the type of the repository uri. When you click inside the input, the entire uri will be selected. Also I have uncluttered the HTML structure. A table is not needed here, nothing a flex block can't handle.
| Before | After |
|-----------|-----------|
| {F1360344} | {F1368592} |
While at it, I have extended the used javascript copy behavior. First of all: `document.execCommand('copy')` [[ https://developer.mozilla.org/en-US/docs/Web/API/Document/execCommand | could stop working every moment in every browser ]]. The [[ https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Interact_with_the_clipboard | new clipboard API ]] is the way to go, so I have implemented it as the preferred method. The old method is kept as a fallback. And I have added a very nice feature: If defined, the behavior will now issue success or error notifications. See the changed UIExamples for that.
To support the shrinking of JS code with async functions I have patched the JsShrink source.
Test Plan: Go to a repository, hit the clone button and use the new copy button. You will see a shiny notification as a reward.
Reviewers: O1 Blessed Committers, avivey, valerio.bozzolan
Reviewed By: O1 Blessed Committers, avivey, valerio.bozzolan
Subscribers: avivey, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D25536
49 lines
1.6 KiB
PHP
49 lines
1.6 KiB
PHP
<?php
|
|
/** Remove spaces and comments from JavaScript code
|
|
* @param string code with commands terminated by semicolon
|
|
* @return string shrinked code
|
|
* @link http://vrana.github.com/JsShrink/
|
|
* @author Jakub Vrana, http://www.vrana.cz/
|
|
* @copyright 2007 Jakub Vrana
|
|
* @license http://www.apache.org/licenses/LICENSE-2.0 Apache License, Version 2.0
|
|
* @license http://www.gnu.org/licenses/gpl-2.0.html GNU General Public License, version 2 (one or other)
|
|
*/
|
|
function jsShrink($input) {
|
|
return preg_replace_callback('(
|
|
(?:
|
|
(^|[-+\([{}=,:;!%^&*|?~]|/(?![/*])|return|throw) # context before regexp
|
|
(?:\s|//[^\n]*+\n|/\*(?:[^*]|\*(?!/))*+\*/)* # optional space
|
|
(/(?![/*])(?:
|
|
\\\\[^\n]
|
|
|[^[\n/\\\\]++
|
|
|\[(?:\\\\[^\n]|[^]])++
|
|
)+/) # regexp
|
|
|(^
|
|
|\'(?:\\\\.|[^\n\'\\\\])*\'
|
|
|"(?:\\\\.|[^\n"\\\\])*"
|
|
|([0-9A-Za-z_$]+)
|
|
|([-+]+)
|
|
|.
|
|
)
|
|
)(?:\s|//[^\n]*+\n|/\*(?:[^*]|\*(?!/))*+\*/)* # optional space
|
|
)sx', 'jsShrinkCallback', "$input\n");
|
|
}
|
|
|
|
function jsShrinkCallback($match) {
|
|
static $last = '';
|
|
$match += array_fill(1, 5, null); // avoid E_NOTICE
|
|
list(, $context, $regexp, $result, $word, $operator) = $match;
|
|
if ($word != '') {
|
|
$result = ($last == 'word' ? "\n" : ($last == 'return' ? " " : "")) . $result;
|
|
$last = ($word == 'return' || $word == 'throw' || $word == 'break' || $word == 'async' ? 'return' : 'word');
|
|
} elseif ($operator) {
|
|
$result = ($last == $operator[0] ? "\n" : "") . $result;
|
|
$last = $operator[0];
|
|
} else {
|
|
if ($regexp) {
|
|
$result = $context . ($context == '/' ? "\n" : "") . $regexp;
|
|
}
|
|
$last = '';
|
|
}
|
|
return $result;
|
|
}
|