mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-11 09:22:40 +01:00
608e1d20b4
Summary: Ref T4896. Depends on D10023. Prepares the code for the final migration. The transaction table stores one row per distinct effect (e.g., add CCs) rather than one row per user action (e.g., "add CCs + comment"). We can double-read that table as long as the code doesn't expect transactions/comments to have multiple different effects, and doesn't try to write any such rows. Everywhere that we were writing a big "X + Y" comment, write two separate "X" and "Y" comments instead. Like D10023, this disrupts the UI a little (you get more boxes), but that will be resolved once the rendering code swaps over. Otherwise, this retains the existing behavior. Test Plan: - Used `diffusion.createcomment` to add comments, raise concern, and accept. - Previewed commenting, adding auditors/ccs, accepting, raising concern. - Actually performed commenting, adding auditors/ccs, accepting, raising concern. - Added a user with mentions. - Added an explicit CC and a mention user. Reviewers: btrahan, joshuaspence Reviewed By: joshuaspence Subscribers: epriestley Maniphest Tasks: T4896 Differential Revision: https://secure.phabricator.com/D10052 |
||
|---|---|---|
| .. | ||
| DiffusionBranchQueryConduitAPIMethod.php | ||
| DiffusionBrowseQueryConduitAPIMethod.php | ||
| DiffusionCommitParentsQueryConduitAPIMethod.php | ||
| DiffusionConduitAPIMethod.php | ||
| DiffusionCreateCommentConduitAPIMethod.php | ||
| DiffusionDiffQueryConduitAPIMethod.php | ||
| DiffusionExistsQueryConduitAPIMethod.php | ||
| DiffusionFileContentQueryConduitAPIMethod.php | ||
| DiffusionFindSymbolsConduitAPIMethod.php | ||
| DiffusionGetCommitsConduitAPIMethod.php | ||
| DiffusionGetLintMessagesConduitAPIMethod.php | ||
| DiffusionGetRecentCommitsByPathConduitAPIMethod.php | ||
| DiffusionHistoryConduitAPIMethod.php | ||
| DiffusionLastModifiedQueryConduitAPIMethod.php | ||
| DiffusionLookSoonConduitAPIMethod.php | ||
| DiffusionMergedCommitsQueryConduitAPIMethod.php | ||
| DiffusionQueryCommitsConduitAPIMethod.php | ||
| DiffusionQueryConduitAPIMethod.php | ||
| DiffusionQueryPathsConduitAPIMethod.php | ||
| DiffusionRawDiffQueryConduitAPIMethod.php | ||
| DiffusionReadmeQueryConduitAPIMethod.php | ||
| DiffusionRefsQueryConduitAPIMethod.php | ||
| DiffusionResolveRefsConduitAPIMethod.php | ||
| DiffusionSearchQueryConduitAPIMethod.php | ||
| DiffusionTagsQueryConduitAPIMethod.php | ||
| DiffusionUpdateCoverageConduitAPIMethod.php | ||