1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 07:12:41 +01:00
phorge-phorge/webroot/rsrc/js/application/diff
epriestley 60e869f411 Make the client authoritative for "Save" actions
Summary:
Ref T13559. When you click "Save" on an inline comment and it's empty, we may actually delete the comment.

Currently, the client and server both make decisions about whether the comment should be deleted. These decisions may not agree, causing the client state to fall out of sync.

Make the client authoritative about whether it wants to handle the user clicking the "Save" button as an intent to save or an intent to delete.

Test Plan: Saved empty and nonempty inlines. See followup changes.

Maniphest Tasks: T13559

Differential Revision: https://secure.phabricator.com/D21648
2021-03-29 09:00:25 -07:00
..
DiffChangeset.js Fix an issue where inlines could be duplicated in the client list 2021-03-29 09:00:23 -07:00
DiffChangesetList.js Make "Open in Editor" use the simple line number of the current selected block 2020-05-21 15:31:16 -07:00
DiffInline.js Make the client authoritative for "Save" actions 2021-03-29 09:00:25 -07:00
DiffInlineContentState.js Make client inlines track an "active" state 2021-03-29 09:00:24 -07:00
DiffPathView.js Make "hidden" changesets sticky, and show hidden state in the filetree 2020-04-22 16:12:42 -07:00
DiffTreeView.js Mark "low importance" and "owned" changes in the filetree 2020-04-22 11:22:34 -07:00