mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-10 00:42:41 +01:00
No description
6146aefcd4
Summary: Fixes T7661. Ref T9527. When you create a task, especially with an EditEngine form, you currently get more noise than is useful. For example: > alice created this task. > alice changed the edit policy from "All Users" to "Community (Project)". > alice added projects: Feature Request, Differential. > alice added a subscriber: alice. Transaction (1) is a little useful, since it saves us from a weird empty state and shows the object creation time. Transaction (2) is totally useless (and even misleading) because that's the default policy for the form. Transaction (3) isn't //completely// useless but isn't very interesting, and probably not worth the real-estate. Transaction (4) is totally useless. (These transactions are uniquely useless when creating objects -- when editing them later, they're fine.) This adds two new rules to hide transactions: - Hide transactions from object creation if the old value is empty (e.g., set title, set projects, set subscribers). - Hide transactions from object creation if the old value is the same as the form default value (e.g., set policy to default, set priorities to default, set status to default). NOTE: These rules also hide the "created this object" transaction, since it's really one of those transaction types in all cases. I want to keep that around in the long term, but just have it be a separate `TYPE_CREATE` action -- currently, it is this weird, inconsistent action where we pick some required field (like title) and special-case the rendering if the old value is `null`. So fixing that is a bit more involved. For now, I'm just dropping these transactions completely, but intend to restore them later. Test Plan: - Created objects. - Usually saw no extra create transactions. - Saw extra create transactions when making an important change away from form defaults (e.g., overriding form policy). Reviewers: chad Reviewed By: chad Maniphest Tasks: T7661, T9527 Differential Revision: https://secure.phabricator.com/D14810 |
||
|---|---|---|
| bin | ||
| conf | ||
| externals | ||
| resources | ||
| scripts | ||
| src | ||
| support | ||
| webroot | ||
| .arcconfig | ||
| .arclint | ||
| .arcunit | ||
| .editorconfig | ||
| .gitignore | ||
| LICENSE | ||
| NOTICE | ||
| README.md | ||
Phabricator is a collection of web applications which help software companies build better software.
Phabricator includes applications for:
- reviewing and auditing source code;
- hosting and browsing repositories;
- tracking bugs;
- managing projects;
- conversing with team members;
- assembling a party to venture forth;
- writing stuff down and reading it later;
- hiding stuff from coworkers; and
- also some other things.
You can learn more about the project (and find links to documentation and resources) at Phabricator.org
Phabricator is developed and maintained by Phacility.
SUPPORT RESOURCES
For resources on filing bugs, requesting features, reporting security issues, and getting other kinds of support, see Support Resources.
NO PULL REQUESTS!
We do not accept pull requests through GitHub. If you would like to contribute code, please read our Contributor's Guide.
LICENSE
Phabricator is released under the Apache 2.0 license except as otherwise noted.