1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 07:12:41 +01:00
phorge-phorge/webroot/rsrc/js/application/differential
epriestley 616976a45c Make inline reticle code more general and robust
Summary:
Ref T2009. Currently, the code which draws the reticle is sort of implicitly hard-coded with some of the rules for the 2up view.

Instead, use general rules:

  - Start selection at the next `<td />`.
  - End selection at the rightmost adjacent `<td />`.

These rules work in all cases.

Test Plan:
  - Activated reticle in 1up and 2up views by clicking line numbers and hovering over comments. It now draws correctly.
  - Dragged over line ranges in 1up and 2up views, saw accurate reticle.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T2009

Differential Revision: https://secure.phabricator.com/D12009
2015-03-07 11:47:55 -08:00
..
behavior-add-reviewers-and-ccs.js Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
behavior-comment-jump.js Various minor JSHint fixes. 2014-07-01 06:00:12 +10:00
behavior-comment-preview.js Diffusion - nuke faulty javascript error handler 2014-08-28 13:08:32 -07:00
behavior-diff-radios.js Bring Javelin into Phabricator via git submodule, not copy-and-paste 2011-05-08 13:20:10 -07:00
behavior-dropdown-menus.js Make "Show Context" persist rendering, whitespace, encoding, etc 2015-03-05 14:03:00 -08:00
behavior-edit-inline-comments.js Make inline reticle code more general and robust 2015-03-07 11:47:55 -08:00
behavior-keyboard-nav.js diffusion / differential - better handle case where no comment selected 2014-11-12 12:26:22 -08:00
behavior-populate.js Merge behavior-show-more into behavior-populate 2015-03-05 14:03:15 -08:00
behavior-show-field-details.js Remove unused JavaScript variables. 2014-06-24 03:27:47 +10:00
behavior-toggle-files.js Better JS for Differential File Collapsing Undo 2013-08-13 16:14:26 -07:00
behavior-user-select.js Enable selecting text in Differential shield and gap 2012-09-20 15:20:47 -07:00
ChangesetViewManager.js Make "Show Context" persist rendering, whitespace, encoding, etc 2015-03-05 14:03:00 -08:00
DifferentialInlineCommentEditor.js Improve behavior of inline rendering with unified views 2015-03-05 14:11:51 -08:00