1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-21 09:48:47 +02:00
phorge-phorge/src/applications/diffusion
epriestley aaab1011e5 Give AphrontTagView a getViewer(), deprecate getUser()
Summary:
Two minor changes here:

  - Replace `get/setUser()` with `get/setViewer()` for consistency with everything else.
  - `getViewer()` now throws if no viewer is set. We had a lot of code that either "should" check this but didn't, or did check it in an identical way, duplicating work. In contrast, very little code checks for a viewer but works if one is not present.

Test Plan:
  - Grepped for `->user`.
  - Attempted to fix all callsites inside `*View` classes.
  - Browsed around a bunch of applications, particularly Calendar, Differential and Diffusion, which seemed most heavily affected.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D15412
2016-03-06 09:27:38 -08:00
..
application Support ID-based repository URIs, and canonicalize repository URIs 2016-02-18 09:56:28 -08:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
conduit Fix limit calculation for largeish Mercurial repsositories 2016-02-16 14:14:59 -08:00
config Move FontIcon calls to Icon 2016-01-28 08:48:45 -08:00
controller Store Almanac "service types" instead of "service classes" 2016-02-26 06:21:50 -08:00
data Parse and display commit authorship date in Git in Diffusion 2016-01-11 09:32:37 -08:00
doorkeeper Partially modernize Doorkeeper/Asana bridge 2014-10-01 07:09:34 -07:00
edge Fix reverting commit language 2015-06-01 09:54:30 +10:00
engine Pass repository PHID to custom hooks in PHABRICATOR_REPOSITORY instead of callsign 2016-02-17 17:10:44 -08:00
engineextension Move PhabricatorHovercard to PHUIHovercard 2016-02-03 16:26:30 +00:00
exception Replace AphrontUsageException with AphrontMalformedRequestException 2015-09-03 10:04:17 -07:00
garbagecollector Support ID-based repository URIs, and canonicalize repository URIs 2016-02-18 09:56:28 -08:00
herald Move various other callsites away from callsigns 2016-01-04 06:54:42 -08:00
panel Add "Mailing List" users 2015-06-03 18:42:33 -07:00
protocol Added an intercept to Mercurial's capabilities command to remove bundle2. 2015-10-10 07:14:48 -07:00
query Allow diffusion.filecontentquery to load data for arbitrarily large files 2016-01-21 09:52:43 -08:00
remarkup Stop all object mentions from matching after "@" 2015-09-29 06:43:49 -07:00
request Remove uncalled DiffusionRequest->getCallsign() 2016-02-17 17:17:35 -08:00
response Allow Phabricator to serve Mercurial repositories over HTTP 2013-11-06 18:00:42 -08:00
ssh Make serving repositories work with alternate URIs 2016-02-18 10:06:03 -08:00
symbol Extend from Phobject 2015-06-15 18:02:27 +10:00
typeahead Improve type and icon information in typeahead 2016-02-05 12:48:20 -08:00
view Give AphrontTagView a getViewer(), deprecate getUser() 2016-03-06 09:27:38 -08:00
DiffusionLintSaveRunner.php Move repository URIs to a dedicated index 2016-01-13 09:34:31 -08:00