1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-24 15:52:41 +01:00
phorge-phorge/src/applications/diffusion
Fabian Stelzer f33e2de092 make repo callsigns optional
Summary:
Ref T4245 Make repo callsigns optional
This is far from done and still very ugly. I'm just submitting it to check if i'm solving this in the right places.
Right now there's three places with duplicate code and building the identifierMap in the CommitQuery is very ugly.
If we only want to support this in the user frontend then i could hack it into the Markup rule itself and not touch the CommitQuery. Even uglier but more limited in scope...

Generally this approach will need a lot of "check this first and then try the other" in a few places.
I could move the Repository queries into a specialised PhabricatorRepositoryQuery method (withCallsignOrID) but i'm not sure about that.

Test Plan:
 - phid.lookup works with R1 and rTEST (which is the same repo)
 - R1 and rTEST euqally work in remarkup (tested in comments).
 - Reviewed the following syntax also all works:
rTEST
rTESTd773137a7cb9
rTEST:d773137a7cb9
R1
R1:d773137a7cb9
d773137a7cb9
{rTEST}
{rTESTd773137a7cb9}
{rTEST:d773137a7cb9}
{R1}
{R1:d773137a7cb9}
{d773137a7cb9}

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Maniphest Tasks: T4245

Differential Revision: https://secure.phabricator.com/D11050
2015-01-01 08:07:26 -08:00
..
application make repo callsigns optional 2015-01-01 08:07:26 -08:00
capability Simplify the implementation of PhabricatorPolicyCapability subclasses 2014-07-25 08:25:42 +10:00
conduit Fix diffusion.readmequery to work in a cluster enviroment 2014-12-31 11:54:52 -08:00
config Change double quotes to single quotes. 2014-06-09 11:36:50 -07:00
controller Migrate Differential revision edges to use modern EdgeType subclasses 2015-01-01 15:07:03 +11:00
data Fix diffusion.readmequery to work in a cluster enviroment 2014-12-31 11:54:52 -08:00
doorkeeper Partially modernize Doorkeeper/Asana bridge 2014-10-01 07:09:34 -07:00
edge Migrate Differential revision edges to use modern EdgeType subclasses 2015-01-01 15:07:03 +11:00
engine Use new FutureIterator instead of Futures 2014-12-30 23:13:38 +11:00
events Migrate Differential revision edges to use modern EdgeType subclasses 2015-01-01 15:07:03 +11:00
exception Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
herald Allow pre-commit adapter to use custom actions 2014-08-28 10:59:30 +10:00
panel Allow users to recover from a missing password hasher 2014-08-21 11:30:05 -07:00
protocol Applied various linter fixes. 2014-06-09 16:04:12 -07:00
query make repo callsigns optional 2015-01-01 08:07:26 -08:00
remarkup make repo callsigns optional 2015-01-01 08:07:26 -08:00
request Show a better message for empty repositories and invalid branches 2014-07-12 07:05:19 -07:00
response Allow Phabricator to serve Mercurial repositories over HTTP 2013-11-06 18:00:42 -08:00
ssh Apply some autofix linter rules 2014-09-10 06:55:05 +10:00
typeahead Rename PhabricatorApplication subclasses 2014-07-23 10:03:09 +10:00
view Fix diffusion.readmequery to work in a cluster enviroment 2014-12-31 11:54:52 -08:00
DiffusionLintSaveRunner.php Use new FutureIterator instead of Futures 2014-12-30 23:13:38 +11:00