1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-25 00:02:41 +01:00
phorge-phorge/src/applications/files/query
epriestley 2e0361bd98 Bind file thumbnail visibility to the visibility of the original files
Summary:
Ref T6013. Currently, when we create a thumbnail, it gets its own (default) file visibility policy.

In particular, this causes the issue in T6013: thumbnails get "all users" visibility, which does not include logged-out users.

Instead, a thumbnail should just have the same visibility as the original file does. Enforce this:

  - When loading thumbnails, reject thumbnails with invisible originals.
  - When filtering thumbnails, permit thumbnails with visible originals.

Test Plan: As a logged-out user, thumbnails are now visible when the original files are attached to visible objects.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T6013

Differential Revision: https://secure.phabricator.com/D10410
2014-09-04 12:49:31 -07:00
..
PhabricatorFileBundleLoader.php Viewerize ArcBundle file loading callbacks 2013-09-30 12:21:33 -07:00
PhabricatorFileQuery.php Bind file thumbnail visibility to the visibility of the original files 2014-09-04 12:49:31 -07:00
PhabricatorFileSearchEngine.php Rename PhabricatorApplication subclasses 2014-07-23 10:03:09 +10:00
PhabricatorFileTransactionQuery.php Remove @group annotations 2014-07-10 08:12:48 +10:00